Sync 5.0.0 with main

[shuyama1]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 82 files changed, 4180 insertions(+), 363 deletions(-))
Terraform Beta: Diff ( 93 files changed, 6963 insertions(+), 425 deletions(-))
TF Conversion: Diff ( 11 files changed, 488 insertions(+))
TF OiCS: Diff ( 26 files changed, 994 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_delivery_pipeline" "primary" {
  serial_pipeline {
    stages {
      strategy {
        canary {
          canary_deployment {
            postdeploy {
              actions = # value needed
            }
            predeploy {
              actions = # value needed
            }
          }
          custom_canary_deployment {
            phase_configs {
              postdeploy {
                actions = # value needed
              }
              predeploy {
                actions = # value needed
              }
            }
          }
          runtime_config {
            kubernetes {
              gateway_service_mesh {
                route_update_wait_time = # value needed
              }
            }
          }
        }
        standard {
          postdeploy {
            actions = # value needed
          }
          predeploy {
            actions = # value needed
          }
        }
      }
    }
  }
}

Resource: google_dataplex_asset (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_asset" "primary" {
  resource_spec {
    read_access_mode = # value needed
  }
}

Resource: google_eventarc_trigger (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
}

[modular-magician]

Tests analytics

Total tests: 2943
Passed tests 2611
Skipped tests: 305
Affected tests: 27

Action taken

Found 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringAlertPolicy|TestAccWorkstationsWorkstationCluster_Private_update|TestAccWorkstationsWorkstationCluster_update|TestAccBillingProjectInfo_update|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample|TestAccContainerCluster_withMonitoringConfig|TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample|TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample|TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig|TestAccContainerNodePool_concurrent|TestAccContainerCluster_withPrivateClusterConfigPrivateEndpointSubnetwork|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccCloudfunctions2function_cloudfunctions2CmekExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccSecretManagerSecret_annotationsUpdate|TestAccSecretManagerSecret_secretWithAnnotationsExample|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample|TestAccBigQueryExternalDataTable_iceberg|TestAccBillingBudget_billingBudgetUpdate|TestAccBigQueryExternalDataTable_queryAcceleration|TestAccBillingBudget_billingFilterSubaccounts|TestAccBigQueryExternalDataTable_objectTable|TestAccBigQueryExternalDataTable_parquetFileSetSpecType|TestAccBillingBudget_billingBudgetFilterExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringAlertPolicy[Debug log]
TestAccWorkstationsWorkstationCluster_Private_update[Debug log]
TestAccWorkstationsWorkstationCluster_update[Debug log]
TestAccBillingProjectInfo_update[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample[Debug log]
TestAccContainerCluster_withMonitoringConfig[Debug log]
TestAccDNSManagedZone_dnsManagedZonePrivateGkeExample[Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Debug log]
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Debug log]
TestAccContainerNodePool_concurrent[Debug log]
TestAccContainerCluster_withPrivateClusterConfigPrivateEndpointSubnetwork[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccCloudfunctions2function_cloudfunctions2CmekExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccSecretManagerSecret_annotationsUpdate[Debug log]
TestAccSecretManagerSecret_secretWithAnnotationsExample[Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Debug log]
TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample[Debug log]
TestAccBigQueryExternalDataTable_iceberg[Debug log]
TestAccBillingBudget_billingBudgetUpdate[Debug log]
TestAccBigQueryExternalDataTable_queryAcceleration[Debug log]
TestAccBillingBudget_billingFilterSubaccounts[Debug log]
TestAccBigQueryExternalDataTable_objectTable[Debug log]
TestAccBigQueryExternalDataTable_parquetFileSetSpecType[Debug log]
TestAccBillingBudget_billingBudgetFilterExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[SarahFrench]

Could this TeamCity-related commit also be pulled in? Thank you!

[shuyama1]

@SarahFrench good point! Thanks for watching this. Just rebase the sync_branch, and it should include the TC change now

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 86 files changed, 4218 insertions(+), 370 deletions(-))
Terraform Beta: Diff ( 97 files changed, 7001 insertions(+), 432 deletions(-))
TF Conversion: Diff ( 11 files changed, 488 insertions(+))
TF OiCS: Diff ( 26 files changed, 994 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_delivery_pipeline" "primary" {
  serial_pipeline {
    stages {
      strategy {
        canary {
          canary_deployment {
            postdeploy {
              actions = # value needed
            }
            predeploy {
              actions = # value needed
            }
          }
          custom_canary_deployment {
            phase_configs {
              postdeploy {
                actions = # value needed
              }
              predeploy {
                actions = # value needed
              }
            }
          }
          runtime_config {
            kubernetes {
              gateway_service_mesh {
                route_update_wait_time = # value needed
              }
            }
          }
        }
        standard {
          postdeploy {
            actions = # value needed
          }
          predeploy {
            actions = # value needed
          }
        }
      }
    }
  }
}

Resource: google_dataplex_asset (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_asset" "primary" {
  resource_spec {
    read_access_mode = # value needed
  }
}

Resource: google_eventarc_trigger (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 86 files changed, 4218 insertions(+), 370 deletions(-))
Terraform Beta: Diff ( 97 files changed, 7001 insertions(+), 432 deletions(-))
TF Conversion: Diff ( 11 files changed, 488 insertions(+))
TF OiCS: Diff ( 26 files changed, 994 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_delivery_pipeline" "primary" {
  serial_pipeline {
    stages {
      strategy {
        canary {
          canary_deployment {
            postdeploy {
              actions = # value needed
            }
            predeploy {
              actions = # value needed
            }
          }
          custom_canary_deployment {
            phase_configs {
              postdeploy {
                actions = # value needed
              }
              predeploy {
                actions = # value needed
              }
            }
          }
          runtime_config {
            kubernetes {
              gateway_service_mesh {
                route_update_wait_time = # value needed
              }
            }
          }
        }
        standard {
          postdeploy {
            actions = # value needed
          }
          predeploy {
            actions = # value needed
          }
        }
      }
    }
  }
}

Resource: google_dataplex_asset (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_asset" "primary" {
  resource_spec {
    read_access_mode = # value needed
  }
}

Resource: google_eventarc_trigger (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 86 files changed, 4218 insertions(+), 370 deletions(-))
Terraform Beta: Diff ( 97 files changed, 7001 insertions(+), 432 deletions(-))
TF Conversion: Diff ( 11 files changed, 488 insertions(+))
TF OiCS: Diff ( 26 files changed, 994 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_delivery_pipeline" "primary" {
  serial_pipeline {
    stages {
      strategy {
        canary {
          canary_deployment {
            postdeploy {
              actions = # value needed
            }
            predeploy {
              actions = # value needed
            }
          }
          custom_canary_deployment {
            phase_configs {
              postdeploy {
                actions = # value needed
              }
              predeploy {
                actions = # value needed
              }
            }
          }
          runtime_config {
            kubernetes {
              gateway_service_mesh {
                route_update_wait_time = # value needed
              }
            }
          }
        }
        standard {
          postdeploy {
            actions = # value needed
          }
          predeploy {
            actions = # value needed
          }
        }
      }
    }
  }
}

Resource: google_dataplex_asset (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_asset" "primary" {
  resource_spec {
    read_access_mode = # value needed
  }
}

Resource: google_eventarc_trigger (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
}

[shuyama1]

Sorry, github <-> GCB communication are experiencing some delays today, so I made a bunch of changes that triggered multiple CI runs and diff reports. I cancelled all previous ones so we should see only one test report now. Apologize for the noise.

[modular-magician]

Tests analytics

Total tests: 2943
Passed tests 2628
Skipped tests: 305
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComposerEnvironment_privateWithWebServerControl|TestAccComposerEnvironmentComposer2_private|TestAccComposerEnvironmentComposer1_private|TestAccComposerEnvironment_composerV2PrivateServiceConnect|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2HighResilience|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccComposerEnvironment_ComposerV2|TestAccCloudBuildTrigger_pubsub_config|TestAccComposerEnvironment_fixPyPiPackages

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComposerEnvironment_privateWithWebServerControl[Debug log]
TestAccComposerEnvironmentComposer2_private[Debug log]
TestAccComposerEnvironmentComposer1_private[Debug log]
TestAccComposerEnvironment_composerV2PrivateServiceConnect[Debug log]
TestAccComposerEnvironment_UpdateComposerV2[Debug log]
TestAccComposerEnvironment_ComposerV2HighResilience[Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]
TestAccCloudBuildTrigger_pubsub_config[Debug log]
TestAccComposerEnvironment_fixPyPiPackages[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[shuyama1]

@trodge this should be ready to review