Skip to content

Update documentation for google_sql_user IAM auth.#8549

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
fotinakis:google_sql_user-update-docs
Aug 4, 2023
Merged

Update documentation for google_sql_user IAM auth.#8549
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
fotinakis:google_sql_user-update-docs

Conversation

@fotinakis

Copy link
Copy Markdown
Contributor

Update documentation for google_sql_user to include example usage for CLOUD_IAM_SERVICE_ACCOUNT, including the correct trimsuffix usage required for GCP Postgres.

Fixes hashicorp/terraform-provider-google#14019

(removed non-applicable acknowledgements)

Release Note Template for Downstream PRs (will be copied)

@google-cla

google-cla Bot commented Aug 3, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 3, 2023
@fotinakis

Copy link
Copy Markdown
Contributor Author

Signed CLA

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 4, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 11 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 1 file changed, 11 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_sql_user does not create IAM SA accounts as documented

3 participants