Feature/l4ilb netlb other protocols ug#8485
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
|
Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 27 insertions(+), 4 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 50 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten |
|
|
|
@trodge I fixed the problem, it should be ok now |
54564d3 to
da3c897
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests:
|
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB * Added test testAccComputeBackendService_withUnspecifiedProtocol * Update mmv1/products/compute/BackendService.yaml * Update mmv1/products/compute/BackendService.yaml * refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol * Create backend_service_unspecified_protocol_simple.tf.erb * Update resource_compute_region_backend_service_test.go.erb * Update resource_compute_region_backend_service_test.go.erb * L3_DEFAULT forwarding rule help clarification * Update ForwardingRule.yaml
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB * Added test testAccComputeBackendService_withUnspecifiedProtocol * Update mmv1/products/compute/BackendService.yaml * Update mmv1/products/compute/BackendService.yaml * refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol * Create backend_service_unspecified_protocol_simple.tf.erb * Update resource_compute_region_backend_service_test.go.erb * Update resource_compute_region_backend_service_test.go.erb * L3_DEFAULT forwarding rule help clarification * Update ForwardingRule.yaml
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB * Added test testAccComputeBackendService_withUnspecifiedProtocol * Update mmv1/products/compute/BackendService.yaml * Update mmv1/products/compute/BackendService.yaml * refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol * Create backend_service_unspecified_protocol_simple.tf.erb * Update resource_compute_region_backend_service_test.go.erb * Update resource_compute_region_backend_service_test.go.erb * L3_DEFAULT forwarding rule help clarification * Update ForwardingRule.yaml
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB * Added test testAccComputeBackendService_withUnspecifiedProtocol * Update mmv1/products/compute/BackendService.yaml * Update mmv1/products/compute/BackendService.yaml * refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol * Create backend_service_unspecified_protocol_simple.tf.erb * Update resource_compute_region_backend_service_test.go.erb * Update resource_compute_region_backend_service_test.go.erb * L3_DEFAULT forwarding rule help clarification * Update ForwardingRule.yaml
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)