Skip to content

Feature/l4ilb netlb other protocols ug#8485

Merged
trodge merged 10 commits into
GoogleCloudPlatform:mainfrom
danielmarzini:feature/l4ilb-netlb-other-protocols-ug
Aug 2, 2023
Merged

Feature/l4ilb netlb other protocols ug#8485
trodge merged 10 commits into
GoogleCloudPlatform:mainfrom
danielmarzini:feature/l4ilb-netlb-other-protocols-ug

Conversation

@danielmarzini

@danielmarzini danielmarzini commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added protocol type: UNSPECIFIED in `google_compute_backend_service` as per [release note](https://cloud.google.com/load-balancing/docs/release-notes#July_24_2023)

@google-cla

google-cla Bot commented Jul 28, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician

Copy link
Copy Markdown
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 27 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 27 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@danielmarzini danielmarzini marked this pull request as ready for review July 28, 2023 23:26
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 50 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 50 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2910
Passed tests 2606
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2910
Passed tests 2606
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFolderIamPolicy_basic|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2910
Passed tests 2607
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@danielmarzini

Copy link
Copy Markdown
Contributor Author

@trodge I fixed the problem, it should be ok now

@melinath

melinath commented Aug 1, 2023

Copy link
Copy Markdown
Member

Reassigning review to @trodge since it sounds like y'all have already been discussing this. By the way, could y'all fix the CLA failure? That would require either @trodge signing a CLA or removing that email address as commit coauthor.

@melinath melinath requested review from trodge and removed request for melinath August 1, 2023 16:36
@trodge trodge force-pushed the feature/l4ilb-netlb-other-protocols-ug branch from 54564d3 to da3c897 Compare August 2, 2023 19:20
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 64 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2920
Passed tests 2618
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB

* Added test testAccComputeBackendService_withUnspecifiedProtocol

* Update mmv1/products/compute/BackendService.yaml

* Update mmv1/products/compute/BackendService.yaml

* refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

* Create backend_service_unspecified_protocol_simple.tf.erb

* Update resource_compute_region_backend_service_test.go.erb

* Update resource_compute_region_backend_service_test.go.erb

* L3_DEFAULT forwarding rule help clarification

* Update ForwardingRule.yaml
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Aug 3, 2023
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB

* Added test testAccComputeBackendService_withUnspecifiedProtocol

* Update mmv1/products/compute/BackendService.yaml

* Update mmv1/products/compute/BackendService.yaml

* refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

* Create backend_service_unspecified_protocol_simple.tf.erb

* Update resource_compute_region_backend_service_test.go.erb

* Update resource_compute_region_backend_service_test.go.erb

* L3_DEFAULT forwarding rule help clarification

* Update ForwardingRule.yaml
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 3, 2023
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB

* Added test testAccComputeBackendService_withUnspecifiedProtocol

* Update mmv1/products/compute/BackendService.yaml

* Update mmv1/products/compute/BackendService.yaml

* refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

* Create backend_service_unspecified_protocol_simple.tf.erb

* Update resource_compute_region_backend_service_test.go.erb

* Update resource_compute_region_backend_service_test.go.erb

* L3_DEFAULT forwarding rule help clarification

* Update ForwardingRule.yaml
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
* Add Terraform support for L3_DEFAULT (all protocol) L4 ILB

* Added test testAccComputeBackendService_withUnspecifiedProtocol

* Update mmv1/products/compute/BackendService.yaml

* Update mmv1/products/compute/BackendService.yaml

* refactor testAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

* Create backend_service_unspecified_protocol_simple.tf.erb

* Update resource_compute_region_backend_service_test.go.erb

* Update resource_compute_region_backend_service_test.go.erb

* L3_DEFAULT forwarding rule help clarification

* Update ForwardingRule.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants