Skip to content

cleanup(tgc): replace terraformvalidator to tgc in ruby code#8534

Merged
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
iyabchen:cleanup-tgc-rb
Aug 4, 2023
Merged

cleanup(tgc): replace terraformvalidator to tgc in ruby code#8534
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
iyabchen:cleanup-tgc-rb

Conversation

@iyabchen

@iyabchen iyabchen commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Clean up: Replace validator to tgc in ruby code. b/293622650

  • Rename file terraform_validator.rb to terraform_tgc.rb
  • Rename folder third_party/validator to thrid_party/tgc
  • Rename folder templates/validator to templates/tgc
  • Docker images are not cleaned up yet.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen iyabchen removed the request for review from NickElliot August 3, 2023 15:44
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2922
Passed tests 2620
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@iyabchen iyabchen removed the request for review from ScottSuarez August 3, 2023 19:13
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2924
Passed tests 2622
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@iyabchen iyabchen requested a review from melinath August 3, 2023 21:10
@iyabchen iyabchen marked this pull request as ready for review August 3, 2023 21:10
@melinath melinath merged commit afa3dde into GoogleCloudPlatform:main Aug 4, 2023
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
…loudPlatform#8534)

* cleanup(tgc): replace terraformvalidator to tgc in ruby code

* support both tgc and validator in compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants