Skip to content

remove unused container code#8553

Merged
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
ScottSuarez:remove-unused-container-code
Aug 4, 2023
Merged

remove unused container code#8553
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
ScottSuarez:remove-unused-container-code

Conversation

@ScottSuarez

Copy link
Copy Markdown
Contributor

@shuyama1

I'm removing some container code that I don't believe you will be altering. Going to go ahead with removing the respective cloud build triggers as well if you have no issue.

I tried to leave the ones that you mentioned as needed for now.

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested a review from shuyama1 August 4, 2023 01:02
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2930
Passed tests 2628
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ScottSuarez. I think these files are safe to go

@ScottSuarez ScottSuarez merged commit 9e3a7b1 into GoogleCloudPlatform:main Aug 4, 2023
@ScottSuarez ScottSuarez deleted the remove-unused-container-code branch August 4, 2023 20:43
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants