Added support for annotations field in google_secret_manager_secret resource#8500
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 234 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccSecretManagerSecret_secretWithAnnotationsExample|TestAccSecretManagerSecret_annotationsUpdate |
|
Rerun these tests in REPLAYING mode to catch issues
|
…t-manager-add-annotations
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 234 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten |
|
|
|
@slevenick Could you please review and merge this PR? |
…esource (GoogleCloudPlatform#8500) * Added support for annotations field in google_secret_manager_secret resource * Adjusted white spaces in Secret.yaml
…esource (GoogleCloudPlatform#8500) * Added support for annotations field in google_secret_manager_secret resource * Adjusted white spaces in Secret.yaml
Added support for annotations field in
google_secret_manager_secretresource.fixes hashicorp/terraform-provider-google#14629
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)