Fixed docs for compute instance templates#8524
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello! I am a robot. It looks like you are a community contributor. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Happy to see you contributing to magic modules @kvanzuijlen - looking forward to more PRs 👍🏼🎉 |
rileykarson
left a comment
There was a problem hiding this comment.
LGTM- this is consistent with the guidance in google_compute_instance: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance#scope. They used to say different things!
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-)) |
|
Thanks for picking this up so fast, much appreciated. Happy to see that several of my colleagues started actively contributing 😎 |
The current docs give incorrect instructions for the scopes field in the compute instance template resources. This PR aims to fix those incorrect instructions.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)