Skip to content

Add shuyama1 to vacation list#8604

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:vacation
Aug 10, 2023
Merged

Add shuyama1 to vacation list#8604
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:vacation

Conversation

@shuyama1

Copy link
Copy Markdown
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@shuyama1 shuyama1 requested review from a team and ScottSuarez and removed request for a team August 10, 2023 15:33
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 merged commit e013755 into GoogleCloudPlatform:main Aug 10, 2023
@shuyama1 shuyama1 deleted the vacation branch August 10, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants