Skip to content

Potential fix for downstream waiter for feature branches#8547

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix_downstream_waiter_for_feature_branches
Aug 4, 2023
Merged

Potential fix for downstream waiter for feature branches#8547
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix_downstream_waiter_for_feature_branches

Conversation

@shuyama1

@shuyama1 shuyama1 commented Aug 3, 2023

Copy link
Copy Markdown
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@shuyama1 shuyama1 requested a review from rileykarson August 3, 2023 19:22
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2926
Passed tests 2624
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@shuyama1 shuyama1 merged commit cc92e1a into GoogleCloudPlatform:main Aug 4, 2023
@shuyama1 shuyama1 deleted the fix_downstream_waiter_for_feature_branches branch August 4, 2023 18:27
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants