Skip to content

Composer network config#8533

Merged
ScottSuarez merged 11 commits into
GoogleCloudPlatform:mainfrom
spapi17:composer_network_config
Aug 10, 2023
Merged

Composer network config#8533
ScottSuarez merged 11 commits into
GoogleCloudPlatform:mainfrom
spapi17:composer_network_config

Conversation

@spapi17

@spapi17 spapi17 commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Adding support for connection type in private environments for Cloud Composer.

fixes: hashicorp/terraform-provider-google#13471

@google-cla

google-cla Bot commented Aug 3, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 27 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 27 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in REPLAYING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 24 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 24 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in REPLAYING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

Comment thread mmv1/third_party/terraform/services/composer/resource_composer_environment.go.erb Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2930
Passed tests 2619
Skipped tests: 302
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComposerEnvironment_privateWithWebServerControl|TestAccComposerEnvironment_composerV2PrivateServiceConnect|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2HighResilience|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccComposerEnvironment_ComposerV2|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironmentComposer2_private|TestAccComposerEnvironmentComposer1_private

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComposerEnvironment_privateWithWebServerControl[Debug log]
TestAccComposerEnvironment_composerV2PrivateServiceConnect[Debug log]
TestAccComposerEnvironment_fixPyPiPackages[Debug log]
TestAccComposerEnvironmentComposer2_private[Debug log]
TestAccComposerEnvironmentComposer1_private[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComposerEnvironment_UpdateComposerV2[Error message] [Debug log]
TestAccComposerEnvironment_ComposerV2HighResilience[Error message] [Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode[Error message] [Debug log]
TestAccComposerEnvironment_ComposerV2[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@spapi17

spapi17 commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment
@ScottSuarez

Copy link
Copy Markdown
Contributor

/gcbrun

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2930
Passed tests 2624
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2HighResilience|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccComposerEnvironment_ComposerV2

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComposerEnvironment_ComposerV2HighResilience[Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComposerEnvironment_UpdateComposerV2[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2939
Passed tests 2636
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComposerEnvironment_UpdateComposerV2

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComposerEnvironment_UpdateComposerV2[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for forcing VPC peerings use in Cloud Composer

4 participants