Skip to content

Add new containers for execution of scripts and directly consume them in generate diffs#8525

Merged
ScottSuarez merged 7 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:alter
Aug 3, 2023
Merged

Add new containers for execution of scripts and directly consume them in generate diffs#8525
ScottSuarez merged 7 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:alter

Conversation

@ScottSuarez

@ScottSuarez ScottSuarez commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

This is part of the work outlined in Allow us to make CI changes confidently. I've taken an initial step to point all these entries points to their new homes and will be setting up triggers to auto build the containers themselves.

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez

Copy link
Copy Markdown
Contributor Author

/gcbrun

2 similar comments
@ScottSuarez

Copy link
Copy Markdown
Contributor Author

/gcbrun

@ScottSuarez

Copy link
Copy Markdown
Contributor Author

/gcbrun

@ScottSuarez ScottSuarez requested a review from trodge August 2, 2023 21:23
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@ScottSuarez ScottSuarez changed the title Add new containers for execution of scripts and directly consume them in our generate diffs Add new containers for execution of scripts and directly consume them in generate diffs Aug 2, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2922
Passed tests 2620
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2922
Passed tests 2620
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@ScottSuarez ScottSuarez merged commit 9690e36 into GoogleCloudPlatform:main Aug 3, 2023
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Aug 3, 2023
… in generate diffs (GoogleCloudPlatform#8525)

* Add new containers for execution of scripts and use them directly for generate diffs.

* re-add terraform-triage-party

* upgrade apk

* force generation of the provider to flex more workflows. vcr, test runs, ect.

* force diff on tgc

* force diff on tgc

* everything is green, revert changes
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 3, 2023
… in generate diffs (GoogleCloudPlatform#8525)

* Add new containers for execution of scripts and use them directly for generate diffs.

* re-add terraform-triage-party

* upgrade apk

* force generation of the provider to flex more workflows. vcr, test runs, ect.

* force diff on tgc

* force diff on tgc

* everything is green, revert changes
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
… in generate diffs (GoogleCloudPlatform#8525)

* Add new containers for execution of scripts and use them directly for generate diffs.

* re-add terraform-triage-party

* upgrade apk

* force generation of the provider to flex more workflows. vcr, test runs, ect.

* force diff on tgc

* force diff on tgc

* everything is green, revert changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants