Skip to content

Sync 5.0.0 with main#491

Merged
modular-magician merged 1 commit into
terraform-google-modules:FEATURE-BRANCH-major-release-5.0.0from
modular-magician:downstream-pr-2d5e1f347c43e9e4e6ebdd0fb1bca79967c74ab1
Aug 10, 2023
Merged

Sync 5.0.0 with main#491
modular-magician merged 1 commit into
terraform-google-modules:FEATURE-BRANCH-major-release-5.0.0from
modular-magician:downstream-pr-2d5e1f347c43e9e4e6ebdd0fb1bca79967c74ab1

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#8599

Sync 5.0.0 with main

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 09cdfb3 into terraform-google-modules:FEATURE-BRANCH-major-release-5.0.0 Aug 10, 2023
@modular-magician modular-magician deleted the downstream-pr-2d5e1f347c43e9e4e6ebdd0fb1bca79967c74ab1 branch November 18, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant