Sync feature branch universal deletion policy#16610
Conversation
…eConfigUpdateDisableAutoscaling (GoogleCloudPlatform#16275)
…for `google_monitoring_notification_channel` (GoogleCloudPlatform#15538) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
…pute_region_backend_service` from beta to v1 to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#16282)
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
Co-authored-by: Riley Karson <rileykarson@google.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_identity_policy" "primary" {
policy_query {
group = # value needed
}
}
Resource: resource "google_compute_firewall_policy_rule" "primary" {
match {
dest_network_scope = # value needed
}
}
Resource: resource "google_compute_instance" "primary" {
scheduling {
maintenance_interval = # value needed
}
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
boot_disk {
initialize_params {
size = # value needed
}
}
network_interface {
vlan = # value needed
}
scheduling {
availability_domain = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
boot_disk {
initialize_params {
size = # value needed
}
}
network_interface {
vlan = # value needed
}
scheduling {
availability_domain = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
on_host_maintenance = # value needed
}
}
Resource: resource "google_compute_organization_security_policy_rule" "primary" {
match {
config {
dest_ip_ranges = # value needed
}
}
}
Resource: resource "google_compute_region_ssl_certificate" "primary" {
private_key_wo = # value needed
private_key_wo_version = # value needed
}
Resource: resource "google_compute_rollout_plan" "primary" {
waves {
selectors {
resource_hierarchy_selector {
included_folders = # value needed
included_organizations = # value needed
included_projects = # value needed
}
}
}
}
Resource: resource "google_compute_service_attachment" "primary" {
consumer_accept_lists {
endpoint_url = # value needed
}
}
Resource: resource "google_compute_ssl_certificate" "primary" {
private_key_wo = # value needed
private_key_wo_version = # value needed
}
Resource: resource "google_compute_vpn_gateway" "primary" {
params {
resource_manager_tags = # value needed
}
}
Resource: resource "google_container_cluster" "primary" {
ip_allocation_policy {
additional_ip_ranges_config {
status = # value needed
}
}
node_pool {
node_config {
sandbox_config {
sandbox_type = # value needed
type = # value needed
}
}
}
}
Resource: resource "google_network_security_authz_policy" "primary" {
http_rules {
to {
operations {
mcp {
methods {
params {
contains = # value needed
suffix = # value needed
}
}
}
}
}
}
}
Resource: resource "google_oracle_database_exadb_vm_cluster" "primary" {
properties {
time_zone {
version = # value needed
}
}
}
Resource: resource "google_sql_database_instance" "primary" {
settings {
data_api_access = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 6118 Click here to see the affected service packages
Action takenFound 83 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
d01762f
into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policy
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.