Fixed edge case where async.include_project + exclude_delete caused compilation error#16586
Merged
melinath merged 1 commit intoMar 3, 2026
Conversation
Member
Author
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
leowonderful
reviewed
Mar 3, 2026
ScottSuarez
approved these changes
Mar 3, 2026
This was referenced Mar 4, 2026
aditikumarii-google
pushed a commit
to aditikumarii-google/magic-modules
that referenced
this pull request
Mar 10, 2026
ChuAmberZhang
pushed a commit
to ChuAmberZhang/magic-modules
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this here: #16532 (review)
If you set async.include_project and exclude_delete it causes a compilation error because the project variable isn't used.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.