Add new RDMA_FALCON_POLICY and ULL_POLICY firewall policy types

[mihhalj]

The firewall policy type field is used to o define which resources the policy can be associated with (depending on the VPC type), and imposes limitations and validations on the rules in the policy.

We introduce the new policy_types values RDMA_FALCON_POLICY and ULL_POLICY which can be used with Falcon and ULL networks. Please not that new values are available only in Regional Network Firewall Policies.

16256

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added new values to `policyType` field in `google_compute_network_firewall_policy`, `google_compute_network_firewall_policy_with_rules`, `google_compute_region_network_firewall_policy`, `google_compute_region_network_firewall_policy_with_rules`.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 12 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 8 files changed, 12 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_network_firewall_policy (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy" "primary" {
  policy_type = # value needed
}

Resource: google_compute_network_firewall_policy_with_rules (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy_with_rules" "primary" {
  policy_type = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1244
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 16 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 10 files changed, 16 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1242
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[cesteve]

Added comments to remove ULL_POLICY from global firewalls policies

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 8 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1242
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1242
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1242
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1242
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1242
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeNetworkFirewallPolicy_networkFirewallPolicyFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test