Remove runfiles usage from the Bazel build#16595
Merged
SirGitsalot merged 5 commits intoMar 3, 2026
Merged
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
melinath
approved these changes
Mar 3, 2026
aditikumarii-google
pushed a commit
to aditikumarii-google/magic-modules
that referenced
this pull request
Mar 10, 2026
ChuAmberZhang
pushed a commit
to ChuAmberZhang/magic-modules
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bunch of changes but most of them are a result of running buildifier for formatting. The main change is to remove the use of
github.com/bazelbuild/rules_goto allow for copybara importing. It's replaced by passing templates as input files rather than runfiles. It will get replaced again at some point in the future (maybe by just a more granular version of this) once the templates build rule is split into multiple rules (right now it's one big glob, so modifying any template causes everything to be rebuilt).