Add textConfig field to Pub/Sub Subscription Cloud Storage config

[dibaskar-google]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

pubsub: added `text_config` field to `google_pubsub_subscription` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[dibaskar-google]

@rileykarson Any update on this approval please?

[rileykarson]

Sorry- got pulled into an escalation and low on cycles.

@modular-magician reassign-reviewer

[dibaskar-google]

@malhotrasagar2212 could you please review this one?

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 81 insertions(+))
google-beta provider: Diff ( 3 files changed, 81 insertions(+))
terraform-google-conversion: Diff ( 4 files changed, 82 insertions(+))

[modular-magician]

Tests analytics

Total tests: 73
Passed tests: 65
Skipped tests: 1
Affected tests: 7

Click here to see the affected service packages

• pubsub

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubSubscriptionCloudStorage_emptyAvroConfig
• TestAccPubsubSubscriptionCloudStorage_serviceAccount
• TestAccPubsubSubscriptionCloudStorage_updateAvro
• TestAccPubsubSubscriptionCloudStorage_updateText
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubSubscriptionCloudStorage_emptyAvroConfig [Debug log]
TestAccPubsubSubscriptionCloudStorage_updateAvro [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccPubsubSubscriptionCloudStorage_serviceAccount [Error message] [Debug log]
TestAccPubsubSubscriptionCloudStorage_updateText [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[dibaskar-google]

@malhotrasagar2212 Will you be able to help reviewing this PR?

[dibaskar-google]

@malhotrasagar2212 Any updates on this one please?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 82 insertions(+))
google-beta provider: Diff ( 3 files changed, 82 insertions(+))
terraform-google-conversion: Diff ( 4 files changed, 83 insertions(+))

[modular-magician]

Tests analytics

Total tests: 73
Passed tests: 68
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages

• pubsub

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubSubscriptionCloudStorage_serviceAccount
• TestAccPubsubSubscriptionCloudStorage_updateText
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubSubscriptionCloudStorage_updateText [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccPubsubSubscriptionCloudStorage_serviceAccount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

@dibaskar-google Could you please check the failures, Thanks.

[dibaskar-google]

@malhotrasagar2212 modified the block now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 83 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 4 files changed, 85 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 73
Passed tests: 66
Skipped tests: 1
Affected tests: 6

Click here to see the affected service packages

• pubsub

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubSubscriptionCloudStorage_emptyAvroConfig
• TestAccPubsubSubscriptionCloudStorage_updateAvro
• TestAccPubsubSubscriptionCloudStorage_updateText
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample
• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubSubscriptionCloudStorage_emptyAvroConfig [Debug log]
TestAccPubsubSubscriptionCloudStorage_updateAvro [Debug log]
TestAccPubsubSubscriptionCloudStorage_updateText [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[dibaskar-google]

@malhotrasagar2212 Can you please review this one.

[malhotrasagar2212]

Hi @dibaskar-google, could you please add a test to verify the behavior when user explicitly add text_config {} block to the cloud_storage_config. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 205 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 205 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 5 files changed, 88 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 142 insertions(+))

[modular-magician]

Tests analytics

Total tests: 74
Passed tests: 72
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• pubsub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageTextExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageTextExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[malhotrasagar2212]

LGTM, Thanks!