Add Observability Project Settings Resource#16532
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
After merging another one of my resources, the compilation for this PR fails: Seems like the autogen can't resolve this and I don't think I can just inject code here, so I turned |
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
melinath
left a comment
There was a problem hiding this comment.
yeah, you've run into a weird edge case of the generator! This is easy to work around. In OrganizationSettings.yaml:
- set
async.include_projecttotrue - set
async.actionsto['create', 'update']. (This is necessary because there's a bug in the template in the case whereexclude_delete: trueand alsoasync.include_project: true.)
Once you do that you shouldn't need the handwritten operation file.
|
I've created #16586 to fix the template bug - you'd still need to |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Description:
This PR introduces the
google_observability_project_settingsresource to Magic Modules for the google-beta provider, part of the broader Observability Settings surface for customers to manage observability compliance configurations across the project, folder and organization structures.Fixes hashicorp/terraform-provider-google#26239
Release Note Template for Downstream PRs (will be copied)