Skip to content

Remove FullUrl#16283

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:rep-op
Feb 3, 2026
Merged

Remove FullUrl#16283
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:rep-op

Conversation

@slevenick

@slevenick slevenick commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Dead code, removing. I'm removing a validate function that shouldn't exist. The empty operation with an AsyncOp block is needed in the current functionality when a user has a handwritten operation. Previously it was filled by having a full_url specified, but that was never used and shouldn't exist
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@slevenick slevenick requested review from ScottSuarez and melinath and removed request for melinath February 3, 2026 00:58
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zero-diff, lgtm. That's a little surprising to me because it certainly looks like it's used...

@slevenick slevenick added this pull request to the merge queue Feb 3, 2026
Merged via the queue into GoogleCloudPlatform:main with commit f6082e0 Feb 3, 2026
26 checks passed
@slevenick slevenick deleted the rep-op branch February 3, 2026 16:53
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Feb 5, 2026
wuchris-g pushed a commit to wuchris-g/magic-modules that referenced this pull request Feb 5, 2026
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
kapoorne-g pushed a commit to kapoorne-g/magic-modules that referenced this pull request Feb 24, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants