test data ingestion: make GetBuilds generic and support untagged queued builds#16298
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
|
||
| func (tc *Client) GetBuilds(state, project, finishCut, startCut string) (Builds, error) { | ||
| url := fmt.Sprintf("https://hashicorp.teamcity.com/app/rest/builds?locator=state:%s,count:500,tag:cron-trigger,project:%s,branch:refs/heads/nightly-test,queuedDate:(date:%s,condition:before),queuedDate:(date:%s,condition:after)&fields=build(id,buildTypeId,buildConfName,webUrl,number,queuedDate,startDate,finishDate)", state, project, finishCut, startCut) | ||
| func (tc *Client) GetBuilds(locator, fields string) (Builds, error) { |
There was a problem hiding this comment.
you could use net/url Values struct here instead of manually building the string: https://pkg.go.dev/net/url#Values
c577f56 to
1a7af71
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
3 similar comments
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1a7af71 to
220cb5b
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Refactored
GetBuildsto support dynamic url parameters. This change enabled us to remove thetag:cron-triggerrequirement specifically for Queued build checks to resolve the issue where queued builds could not be retrieved with the tag filter.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.