Add support for dynamic nic to GCE instance/template

[rileykarson]

Supports https://docs.cloud.google.com/vpc/docs/create-use-multiple-interfaces#example-dynamic but not yet https://docs.cloud.google.com/vpc/docs/add-dynamic-nics as the update code is gonna be fun to work out.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added support for `network_interface.0.vlan` to `google_compute_instance`, enabling dynamic NIC. Creating and deleting from an existing instance is not yet supported.

compute: added support for `network_interface.0.vlan` to `google_compute_instance_template`, enabling dynamic NIC

compute: added support for `network_interface.0.vlan` to `google_compute_region_instance_template`, enabling dynamic NIC

compute: added support for `network_interface.0.network_attachment` to `google_compute_region_instance_template`

compute: added support for `network_interface.0.network_attachment` to `google_compute_instance_template` (GA)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 291 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 197 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Resource: google_compute_instance_from_template (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]

[zli82016]

It looks like the unit test failed as the fields need to be added to the meta.yaml files

--- FAIL: TestValidateResourceMetadata (0.52s)
    resource_inventory_test.go:231: Field in provider resource; missing in meta.yaml: google_compute_instance.network_interface.parent_nic_name
    resource_inventory_test.go:231: Field in provider resource; missing in meta.yaml: google_compute_instance.network_interface.vlan
    resource_inventory_test.go:231: Field in provider resource; missing in meta.yaml: 

[modular-magician]

🔴 The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR.
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 491 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 399 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Resource: google_compute_instance_from_template (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Resource: google_compute_region_instance_template (80 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    network_attachment = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]

[zli82016]

Failed tgc integration test is unrelated.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeInstanceTemplate_NetworkAttachment

Tests analytics

Total tests: 1334
Passed tests: 1244
Skipped tests: 86
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_dynamicNic
• TestAccComputeInstance_dynamicNic
• TestAccComputeRegionInstanceTemplate_dynamicNic
• TestAccComputeRegionInstanceTemplate_networkAttachment

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 488 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 396 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Resource: google_compute_instance_from_template (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplate_dynamicNic [Debug log]
TestAccComputeInstance_dynamicNic [Debug log]
TestAccComputeRegionInstanceTemplate_dynamicNic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionInstanceTemplate_networkAttachment [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[zli82016]

LGTM if all of the tests pass.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeInstanceTemplate_NetworkAttachment

Tests analytics

Total tests: 1334
Passed tests: 1247
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionInstanceTemplate_networkAttachment

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionInstanceTemplate_networkAttachment [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 481 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 396 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Resource: google_compute_instance_from_template (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    vlan = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [network_interface.parent_nic_name network_interface.vlan]

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeInstanceTemplate_NetworkAttachment

Tests analytics

Total tests: 1334
Passed tests: 1248
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log