Promote network security mirroring broker to GA.#16286
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Non-exercised tests🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 78 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
@SirGitsalot, the For full context see my previous comment on the PR that introduced the field: #15212 (comment) The same reasoning applies here as well, and this change is completely safe so |
SirGitsalot
left a comment
There was a problem hiding this comment.
Added the override breaking change label as the field is already in beta as-is, and the default matches the API default.
Promoting the Network Security Mirroring Broker resources and properties to GA, which includes changes to:
google_network_security_mirroring_endpointgoogle_network_security_mirroring_endpoint_groupAPIs have already been promoted to v1.