Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource#16242
Conversation
…de, and realtimeUpdatesModes parameters in the google_firestore_database resource
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_firestore_database" "primary" {
firestore_data_access_mode = # value needed
mongodb_compatible_data_access_mode = # value needed
realtime_updates_mode = # value needed
}
|
Tests analyticsTotal tests: 30 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 31 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 31 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 31 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 31 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 31 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 32 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
roaks3
left a comment
There was a problem hiding this comment.
LGTM, we can submit after the last change is made
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 33 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 33 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
I believe this failed due to maintenance being done and the main branch getting locked |
b2e08f7
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
Add support for
firestoreDataAccessMode,mongodbCompatibleDataAcessMode, andrealtimeUpdatesModeparameters in thegoogle_firestore_databaseresourceRelease Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.