Skip to content

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource#16242

Merged
roaks3 merged 12 commits into
GoogleCloudPlatform:mainfrom
NickChittle:data_access_modes
Feb 5, 2026
Merged

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource#16242
roaks3 merged 12 commits into
GoogleCloudPlatform:mainfrom
NickChittle:data_access_modes

Conversation

@NickChittle

@NickChittle NickChittle commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

firestore: add `firestore_data_access_mode`, `mongodb_compatible_data_acess_mode`, and `realtime_updates_mode` fields to the `google_firestore_database` resource

…de, and realtimeUpdatesModes parameters in the google_firestore_database resource
@github-actions github-actions Bot requested a review from roaks3 January 27, 2026 21:13
@github-actions

Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 93 insertions(+))
google-beta provider: Diff ( 3 files changed, 93 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firestore_database (33 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firestore_database" "primary" {
  firestore_data_access_mode          = # value needed
  mongodb_compatible_data_access_mode = # value needed
  realtime_updates_mode               = # value needed
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 30
Passed tests: 30
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

🟢 All tests passed!

View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Comment thread mmv1/templates/terraform/examples/firestore_database_data_access.tf.tmpl Outdated
Comment thread mmv1/products/firestore/Database.yaml Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 150 insertions(+))
google-beta provider: Diff ( 4 files changed, 150 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 151 insertions(+))
google-beta provider: Diff ( 4 files changed, 151 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@NickChittle NickChittle requested a review from roaks3 February 2, 2026 16:50
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 176 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 176 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 32
Passed tests: 31
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • firestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreDatabase_firestoreDatabaseDataAccessTestExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessTestExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can submit after the last change is made

Comment thread mmv1/products/firestore/Database.yaml
@NickChittle NickChittle requested a review from roaks3 February 4, 2026 19:44
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 160 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 160 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 33
Passed tests: 33
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

🟢 All tests passed!

View the build log

@roaks3 roaks3 added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Feb 4, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@github-actions github-actions Bot requested a review from roaks3 February 5, 2026 15:45
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 160 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 160 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 33
Passed tests: 33
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

🟢 All tests passed!

View the build log

@roaks3

roaks3 commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

I believe this failed due to maintenance being done and the main branch getting locked

@roaks3 roaks3 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b2e08f7 Feb 5, 2026
25 of 26 checks passed
wuchris-g pushed a commit to wuchris-g/magic-modules that referenced this pull request Feb 5, 2026
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
18811376770 pushed a commit to 18811376770/magic-modules that referenced this pull request Feb 11, 2026
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
…sMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource (GoogleCloudPlatform#16242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants