Test, will update later#8849
Closed
pengq-google wants to merge 37 commits into
Closed
Conversation
* first draft for new Network Attachment resource * updated NetworkAttachment specification file * added usage example for Network Attachment with GCE Instance * verified attributes and descriptions * enhanced network attachment examples
…GoogleCloudPlatform#8764) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
* Add: BigLake api Database Resource * add: database example * add: database update test * update: test fields * update: mark `catalog_id` required + immutable * update: `type` field. use string, mark required * update: mark hiveoptions req
…rations (GoogleCloudPlatform#8690) * Add `artifactRules` to all build configurations * Set logging ENVs on builds via `TerraformLoggingParameters` * Fix copy+paste error in function signature * Remove space in parameter name * Add `PROVIDER_NAME` * Fix logging-related parameters to be environment varaibles, not configuration parameters * Change log files to use .txt extension, so they open in browser without downloading
Co-authored-by: Edward Sun <sunedward@google.com>
* Update dataplex_datascan_full_profile.tf.erb Add an export table * Add env vars for export table * Fix datascan and dataset references for full datascan example. * Use a var for datascan name across all the examples. * update resource name * update resource name for IAM
…form#8757) * Fully supporting Dialogflow CX Page and Flow objects This fills out a bunch of stuff that was missing including: - repromptEventHandlers (hashicorp/terraform-provider-google#14573) - setParameterActions (hashicorp/terraform-provider-google#14572) - payload, and other fulfillment messages (hashicorp/terraform-provider-google#12946) * Allowing JSON values to actually be values (instead of just objects) * Adding "basic" Flow creation, filling out "full" Flow creation with (I hope) all params * Oops, missed Flow messages.response_type example * Adding "basic" Page creation, filling out "full" Page creation with (I hope) all params * Oops, missed response_type and had an extra level of nested messages{} somehow * Adding return_partial_response + webhook (?!) * Fixing conditionalCases: it's now a JSON encoded list, instead of a list of JSON encoded objects * Normalizing whitespace in examples + tests; it's now all spaces (I hope) * Fixing examples / tests * Normalizing whitespace in basic examples * Fixing examples: empty conditions are supposed to be null / missing * Fixing examples: tag should only be set when webhook is set (we'll see if I need to set webhook everywhere) * Fixing code: responseType is ignored when creating/updating resources
…loudPlatform#8790) * Switched biglake database to use parent field implementation * Added custom import * Switched to id_format / import_format * Fixed biglake database test file path * Fixed function names
…rm#8786) * Renamed breaking-change-detector -> diff-processor * Removed printf statements * Removed debugging lines
…s.customerManagedEncryption to google_secret_manager_secret resource (GoogleCloudPlatform#8755)
…code between packages to allow tests (GoogleCloudPlatform#8797) * Add initial version of plugin framework provider config test affected by inaccessible functions * Move `ReplaceVarsForFrameworkTest` to `fwresource` package This mirrors how old, ReplaceVars* functions are in the `tpgresource` package * Move functions for changing ENVs in tests to `acctest` package, update usage * Move `GenerateFakeCredentialsJson` function to `acctest` package, update usage * Refactor provider config tests to use plugin-framework types * Add all test cases to match equivalent SDK provider config tests Some test cases currently fail due to different handling of empty values by the SDK and plugin framework * Add test case about handling of Unknown values for `project` * Update tests to check values in BOTH the data model and provider config struct after `LoadAndValidateFramework` runs
* initial request_timeout test in providerConfigure * initial requestReason test in providerConfigure * initial batching test in providerConfigure * complete requestTimeout test * complete requestReason test * batch block testing * complete batching test * add more info in test cases * typos * remove redundant SDKDefault_RequestReason test * refactor ExpectedEnableBatchingValue * add ExpectedSendAfterValue check when enable_batching is only set * add info about default sendafter value and new edgecase * add valid request_timeout test case * Update mmv1/third_party/terraform/provider/provider_internal_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/provider/provider_internal_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/provider/provider_internal_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/provider/provider_internal_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/provider/provider_internal_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update mmv1/third_party/terraform/provider/provider_internal_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * add credentials into batching tests * go fmt * add missing credentials in config tests * Add missing refactoring changes, add credentials info --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Sarah French <sarah.french@hashicorp.com>
Co-authored-by: Edward Sun <sunedward@google.com>
…tform#8641) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20221014081412-f15817d10f9b to 0.7.0. - [Commits](https://github.com/golang/net/commits/v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Switched to cobra-based CLI creation This will allow us to easily support multiple subcommands and have more friendly handling of command-line options and testing of command logic. * Moved comparison_test as well
* tgc clean up: rename docker scripts * fix test script filename
…ucket in iam binding examples (GoogleCloudPlatform#8835)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the default value of unique_writer_identity in resource logging_project_sink to true. unique_writer_identity = false is legacy behavior. New sinks should always set this field to be true.
Release Note Template for Downstream PRs (will be copied)