Fixes to provider config code unit tests#8819
Merged
Merged
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-)) |
slevenick
approved these changes
Aug 31, 2023
Contributor
Author
|
Thanks! I can see the unit test checks have passed but I'll lets the other checks finish before merging |
Merged
7 tasks
Collaborator
Tests analyticsTotal tests:
|
This was referenced Aug 31, 2023
5 tasks
ScottSuarez
added a commit
that referenced
this pull request
Aug 31, 2023
This reverts commit 61786f3.
RileyHYZ
pushed a commit
to RileyHYZ/magic-modules
that referenced
this pull request
Sep 15, 2023
joelkattapuram
pushed a commit
to joelkattapuram/magic-modules
that referenced
this pull request
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for unit tests that got to the downstream: https://github.com/hashicorp/terraform-provider-google/actions/runs/6031579309/job/16365486685
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)