Skip to content

Fix TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseC#8764

Merged
ScottSuarez merged 2 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:fix-TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
Aug 28, 2023
Merged

Fix TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseC#8764
ScottSuarez merged 2 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:fix-TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

Conversation

@ScottSuarez

Copy link
Copy Markdown
Contributor

fixes two tests TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

test error

        Error: Error creating Secret: googleapi: Error 409: Secret [projects/****/secrets/secret] already exists.
          with google_secret_manager_secret.secret,
          on terraform_plugin_test.tf line 7, in resource "google_secret_manager_secret" "secret":
           7: resource "google_secret_manager_secret" "secret" {

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested review from a team and melinath and removed request for a team August 25, 2023 00:44
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2988
Passed tests 2689
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample|TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample|TestAccFolderIamPolicy_basic

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Debug log]
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Comment thread mmv1/templates/terraform/examples/dataform_repository_workflow_config.tf.erb Outdated
…_config.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2990
Passed tests 2693
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ScottSuarez ScottSuarez merged commit bf66cc4 into GoogleCloudPlatform:main Aug 28, 2023
@ScottSuarez ScottSuarez deleted the fix-TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample branch August 28, 2023 20:57
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
…GoogleCloudPlatform#8764)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 29, 2023
…GoogleCloudPlatform#8764)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
…GoogleCloudPlatform#8764)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…GoogleCloudPlatform#8764)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants