Skip to content

Update PULL_REQUEST_TEMPLATE.md#8332

Merged
shuyama1 merged 1 commit into
mainfrom
shuyama1-patch-5
Sep 1, 2023
Merged

Update PULL_REQUEST_TEMPLATE.md#8332
shuyama1 merged 1 commit into
mainfrom
shuyama1-patch-5

Conversation

@shuyama1

Copy link
Copy Markdown
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@shuyama1 shuyama1 requested a review from melinath July 12, 2023 22:08
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@melinath

Copy link
Copy Markdown
Member

@shuyama1 would it be possible to get this merged?

@shuyama1

shuyama1 commented Sep 1, 2023

Copy link
Copy Markdown
Member Author

oops, sorry, forgot about this PR. I'll resolve conflicts and merge after

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2712
Skipped tests: 296
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@shuyama1 shuyama1 merged commit 6842488 into main Sep 1, 2023
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Sep 5, 2023
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
@slevenick slevenick deleted the shuyama1-patch-5 branch February 18, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants