Update dataplex_datascan_full_profile.tf.erb by saurabh-net · Pull Request #8700 · GoogleCloudPlatform/magic-modules

saurabh-net · 2023-08-18T00:09:17Z

Add an example using the export BigQuery table feature.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Add an export table

modular-magician · 2023-08-18T00:10:08Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-08-18T00:17:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 34 insertions(+))
Terraform Beta: Diff ( 2 files changed, 34 insertions(+))

modular-magician · 2023-08-18T01:27:59Z

Tests analytics

Total tests: 2968
Passed tests 2664
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccServiceAccountIamPolicy

Get to know how VCR tests work

modular-magician · 2023-08-18T01:32:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Debug log]
TestAccServiceAccountIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

modular-magician · 2023-08-24T23:43:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 34 insertions(+))
Terraform Beta: Diff ( 2 files changed, 34 insertions(+))

modular-magician · 2023-08-25T00:54:27Z

Tests analytics

Total tests: 2988
Passed tests 2688
Skipped tests: 296
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

modular-magician · 2023-08-25T01:01:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath · 2023-08-25T21:09:38Z

+}
+
+resource "google_bigquery_dataset" "source" {
+  dataset_id                  = "dataplex_dataset_%{random_suffix}"


I think this should be:

Suggested change

dataset_id = "dataplex_dataset_%{random_suffix}"

dataset_id = "<%= ctx[:vars]['dataset_name'] %>"

it would be great to make the datascan_id earlier in this example also use a var - basically the reason we do it this way is so that the user-facing documentation has friendly names, but the tests use a tf-test prefix + random suffix, generated from the same example.

Ahh i just realized that I added test to the var name as well, so it says "tf-test-test-datascan%{random_suffix}".

I think it's only for internal code, not public facing, but let me submit a commit to clean it up anyways.

modular-magician · 2023-08-28T19:56:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 47 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+), 13 deletions(-))

modular-magician · 2023-08-28T20:59:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 47 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+), 13 deletions(-))

modular-magician · 2023-08-28T22:15:21Z

Tests analytics

Total tests: 2995
Passed tests 2692
Skipped tests: 296
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanBasicProfileExample|TestAccDataplexDatascan_dataplexDatascanFullQualityExample|TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-28T22:26:57Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample[Debug log]
TestAccDataplexDatascan_dataplexDatascanFullQualityExample[Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascanIamMemberGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamBindingGenerated[Error message] [Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath

Getting close, just one more change probably.

modular-magician · 2023-08-29T00:33:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 52 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 3 files changed, 52 insertions(+), 18 deletions(-))

modular-magician · 2023-08-29T01:47:05Z

Tests analytics

Total tests: 2996
Passed tests 2697
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascanIamMemberGenerated|TestAccDataplexDatascanIamBindingGenerated|TestAccDataplexDatascanIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-08-29T01:53:21Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascanIamMemberGenerated[Debug log]
TestAccDataplexDatascanIamBindingGenerated[Debug log]
TestAccDataplexDatascanIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

* Update dataplex_datascan_full_profile.tf.erb Add an export table * Add env vars for export table * Fix datascan and dataset references for full datascan example. * Use a var for datascan name across all the examples. * update resource name * update resource name for IAM

Update dataplex_datascan_full_profile.tf.erb

5c751ba

Add an export table

modular-magician requested a review from melinath August 18, 2023 00:10

melinath requested changes Aug 18, 2023

View reviewed changes

Comment thread mmv1/templates/terraform/examples/dataplex_datascan_full_profile.tf.erb Outdated

Add env vars for export table

0a1bf67

modular-magician requested a review from melinath August 24, 2023 23:34

melinath requested changes Aug 25, 2023

View reviewed changes

Fix datascan and dataset references for full datascan example.

e2af3b0

modular-magician requested a review from melinath August 28, 2023 19:44

Use a var for datascan name across all the examples.

6e639cc

update resource name

8102c9f

melinath requested changes Aug 28, 2023

View reviewed changes

Comment thread mmv1/products/dataplex/Datascan.yaml Outdated

update resource name for IAM

0251ba5

modular-magician requested a review from melinath August 29, 2023 00:23

Merge branch 'main' into add-export-example

9d0b930

melinath approved these changes Aug 29, 2023

View reviewed changes

melinath merged commit d1908d3 into GoogleCloudPlatform:main Aug 29, 2023

	dataset_id = "dataplex_dataset_%{random_suffix}"
	dataset_id = "<%= ctx[:vars]['dataset_name'] %>"

Conversation

saurabh-net commented Aug 18, 2023

Uh oh!

modular-magician commented Aug 18, 2023

Uh oh!

modular-magician commented Aug 18, 2023

Diff report

Uh oh!

modular-magician commented Aug 18, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 18, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

Uh oh!

modular-magician commented Aug 24, 2023

Diff report

Uh oh!

modular-magician commented Aug 25, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 25, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

melinath Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

melinath Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

saurabh-net Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Aug 28, 2023

Diff report

Uh oh!

modular-magician commented Aug 28, 2023

Diff report

Uh oh!

modular-magician commented Aug 28, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 28, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Aug 29, 2023

Diff report

Uh oh!

modular-magician commented Aug 29, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 29, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants