Skip to content

add beta to a doc#8782

Merged
edwardmedia merged 1 commit into
GoogleCloudPlatform:mainfrom
edwardmedia:issue15640
Aug 29, 2023
Merged

add beta to a doc#8782
edwardmedia merged 1 commit into
GoogleCloudPlatform:mainfrom
edwardmedia:issue15640

Conversation

@edwardmedia

@edwardmedia edwardmedia commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

Fixes hashicorp/terraform-provider-google#15640

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@edwardmedia edwardmedia changed the title add beta in to a doc add beta to a doc Aug 28, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 5 deletions(-))

@edwardmedia edwardmedia merged commit 7ad52b5 into GoogleCloudPlatform:main Aug 29, 2023
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 29, 2023
Co-authored-by: Edward Sun <sunedward@google.com>
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
Co-authored-by: Edward Sun <sunedward@google.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Co-authored-by: Edward Sun <sunedward@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flex templates not implemented

3 participants