Skip to content

Hotfixes release for sprint ending 2021-05-10#3142

Merged
rtibbles merged 51 commits intolearningequality:hotfixesfrom
bjester:sprint-release-2021-05-10
May 12, 2021
Merged

Hotfixes release for sprint ending 2021-05-10#3142
rtibbles merged 51 commits intolearningequality:hotfixesfrom
bjester:sprint-release-2021-05-10

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented May 10, 2021 •
edited
Loading

Summary

  • Adds support for uploading WebM videos
  • Adds support for user-scoped feature flags
  • Adds user-scoped feature for marking an exercise as a channel quiz
  • Fixes issue where changes to a channel's details appear get reverted
  • Fixes email validation in channel invitations
  • Further KDS integration
  • Security updates
PR Issue Category QA Focus
#2973 Enhancement Upload WebM and MP4 videos
#3129 #3120 Enhancement Enable/disable feature flag
#3137 #3119 Enhancement Enable/disable feature flag
Mark exercise as channel quiz as admin
Mark exercise as channel quiz as non-admin
#3075 Enhancement View info modals while editing a resource
#3143 Enhancement N/A
#3130 #3021 Bug fix Invite channel viewer/editor
#3132 #2888, #3018 Bug fix Edit channel details
#3128 #804 Dev enhancement N/A
#3116 Tech debt N/A
#3131, #3136 Security update N/A
#3139 Security update N/A
#3140 Security update N/A

QA Scenarios

Upload WebM and MP4 videos

  1. Open an editable channel
  2. Click ADD and select Upload files
  3. Upload an MP4 video
  4. Finalize the details of the video resource
  5. Add captions for the video
  6. Verify everything is saved and functions as expected
  7. Repeat the above with a WebM video

Enable/disable feature flag

  1. Sign into Studio as an admin
  2. Open the Administration page
  3. Click on the Users tab
  4. Click on a user to view their details
  5. Toggle a feature flag for their account
  6. Refresh
  7. Verify that the setting was saved

Mark exercise as channel quiz as admin

  1. Sign into Studio as an admin
  2. Open an editable channel that contains exercises
  3. Edit an exercise
  4. Verify you see a checkbox option to Allow as a channel quiz underneath Randomize question order...
  5. Toggle the checkbox
  6. Save the changes
  7. Verify your changes saved successfully

Mark exercise as channel quiz as non-admin

  1. Sign in as a non-admin user
  2. Open an editable channel
  3. Edit an exercise
  4. Verify you don't see a checkbox option to Allow as a channel quiz underneath Randomize question order...
  5. Repeat Enable/disable feature flag, enabling the channel quiz feature for the non-admin user
  6. Sign in as the non-admin user again
  7. Open an editable channel
  8. Edit an exercise
  9. Verify you now see a checkbox option to Allow as a channel quiz underneath Randomize question order...
  10. Toggle the checkbox
  11. Save the changes
  12. Verify your changes saved successfully

View info modals while editing a resource

  1. Open an editable channel
  2. Edit an exercise
  3. Click on the ? icons next to any fields to launch the info modals
  4. Verify the info modals display appropriately

Invite channel viewer/editor

  1. Sign into studio
  2. From My Channels, edit a channel's details
  3. Click the Sharing tab
  4. Verify valid email addresses can be invited but invalid email addresses cannot

Edit channel details

  1. Open an editable channel
  2. Edit the channel details
  3. Save your changes
  4. Close the channel details
  5. Re-open to edit the channel details
  6. Verify your changes have persisted

MisRob and others added 30 commits April 8, 2021 10:26
@MisRob
Replace ResponsiveDialog by KModal
c576dd1
@sophianyberg
Push Copyright year to 2021
f6b9d0d
@bjester
Add feature_flags field to User modal
3160648
@rtibbles
Add migration check to tests.
594b025 
Remove meaningless codecov reports.
@bjester
Feature flag manipulation in Studio admin
7305303
@bjester
Remove dead code, update comment
bf1f600
@rtibbles
Enhance email regex, add copious examples to ensure it is not too res…
0fa3121 
…trictive.
@bjester
Merge pull request learningequality#3128 from rtibbles/migrations-ci-…
88bf110 
…check

Add migration check to tests.
@rtibbles
Merge pull request learningequality#3130 from rtibbles/email_validation
26319f9 
Enhance email regex to catch common errors
@bjester
Fix feature flag validation exceptions and test
0c39552
@bjester
Add description and way to exclude feature from non-dev
eade831
@bjester
Fix python requirements
42bcc11
@bjester
Fix loading of static files through Jest
edd44c7
@bjester
Add to garbage_collect command cleanup for feature flags
1ae860b
@bjester
Fix admin Vuex test
9ee7563
@bjester
Fix python test and ensure no additional properties are allowed + com…
d889c0c 
…ments
@rtibbles
Use setData for model fetches as well as collection fetches.
b5e457e
@rtibbles
Merge pull request learningequality#3129 from bjester/feature-flags
9dde3fd 
Feature flag support
@dependabot
Bump rsa from 4.1 to 4.7
8dc7464 
Bumps [rsa](https://github.com/sybrenstuvel/python-rsa) from 4.1 to 4.7.
- [Release notes](https://github.com/sybrenstuvel/python-rsa/releases)
- [Changelog](https://github.com/sybrenstuvel/python-rsa/blob/main/CHANGELOG.md)
- [Commits](sybrenstuvel/python-rsa@version-4.1...version-4.7)

Signed-off-by: dependabot[bot] <support@github.com>
@rtibbles
Merge pull request learningequality#3131 from learningequality/depend…
4b74a84 
…abot/pip/rsa-4.7

Bump rsa from 4.1 to 4.7
@bjester
Merge pull request learningequality#3132 from rtibbles/set_data_model
b7be4bd 
Use setData for model fetches as well as collection fetches.
@sairina @bjester
Add web format
28a2d18
@sairina @bjester
Add translated webm strings
acaaf32
@sairina @bjester
Add test for ThumbnailGenerator.vue
bd245cc
@sairina @bjester
Add test for FilePreview for webm files
1320a7f
@sairina @bjester
Add test for uploader for webm
f7ea6f2
@sairina @bjester
Add webm format to test
c786b43
@sairina @bjester
Add le-utils version 0.1.27
56e3ab2
@sairina @bjester
Fix linting
966baaf
@sairina @bjester
Complete le-utils upgrade
53dbba7
sairina and others added 21 commits May 4, 2021 10:09
@sairina @bjester
Fix linting
20f28f7
@bjester
Requirements update
ff76194
@bjester
Resolve migration conflicts
c5b24dd
@bjester
Add migrations for format preset changes
07fb3ca
@bjester
Merge pull request learningequality#2973 from sairina/webm
f164515 
New feature: Add webm file format to Studio
@dependabot
Bump rsa from 4.0 to 4.7
0e9d222 
Bumps [rsa](https://github.com/sybrenstuvel/python-rsa) from 4.0 to 4.7.
- [Release notes](https://github.com/sybrenstuvel/python-rsa/releases)
- [Changelog](https://github.com/sybrenstuvel/python-rsa/blob/main/CHANGELOG.md)
- [Commits](sybrenstuvel/python-rsa@version-4.0...version-4.7)

Signed-off-by: dependabot[bot] <support@github.com>
@bjester
User-scoped channel quiz feature
f2332f6
@bjester
Change copy
dcd5729
@bjester
Linting fixes
ba5b51d
@rtibbles
Merge pull request learningequality#3137 from bjester/channel-quiz
e1ac641 
User-scoped channel quiz feature
@rtibbles
Merge pull request learningequality#3136 from learningequality/depend…
f0f4f66 
…abot/pip/rsa-4.7

Bump rsa from 4.0 to 4.7
@dependabot
Bump lodash from 4.17.19 to 4.17.21
64fc46a 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
@rtibbles
Merge pull request learningequality#3139 from learningequality/depend…
58bc34f 
…abot/npm_and_yarn/lodash-4.17.21

Bump lodash from 4.17.19 to 4.17.21
@dependabot
Bump hosted-git-info from 2.8.8 to 2.8.9
7f9f17e 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>
@bjester
Merge pull request learningequality#3116 from sophianyberg/patch-1
d3054cc 
Push Copyright year to 2021
@bjester
Merge pull request learningequality#3140 from learningequality/depend…
80cf7f2 
…abot/npm_and_yarn/hosted-git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
@bjester
Merge pull request learningequality#3075 from MisRob/kds-kmodal-respo…
88308b4 
…nsivedialog-infomodal

KDS to Studio: Replace ResponsiveDialog by KModal in InfoModal
@bjester
Fix merge conflict in User viewset
6514720
@rtibbles
Merge pull request learningequality#3141 from bjester/merge-down-prer…
979a544 
…elease-2021-05-10

Merge down for Sprint release 2021-05-10
@rtibbles
Upgrade le utils for QTI preset.
6d50d19
@bjester
Merge pull request learningequality#3143 from rtibbles/leutils0.1.30
8f72bce 
Upgrade le utils for QTI preset.
@bjester bjester marked this pull request as ready for review May 11, 2021 22:30
@bjester bjester requested a review from radinamatic May 11, 2021 22:30
radinamatic
radinamatic approved these changes May 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro-forma approving this so it can be merged and deployed on the hotfixes branch for further QA 👍🏽

@rtibbles rtibbles merged commit 7463483 into learningequality:hotfixes May 12, 2021
@radinamatic
Copy link
Copy Markdown
Member

radinamatic commented May 13, 2021

Results of my testing today, and unless @pcenov finds any issues, this is looking good! 💯

PR Issue Category QA Focus Status
#2973 Enhancement Upload WebM and MP4 videos ✔️
#3129 #3120 Enhancement Enable/disable feature flag ✔️
#3137 #3119 Enhancement Enable/disable feature flag
Mark exercise as channel quiz as admin
Mark exercise as channel quiz as non-admin		 ✔️
✔️
✔️
#3075 Enhancement View info modals while editing a resource ✔️
#3130 #3021 Bug fix Invite channel viewer/editor ✔️
#3132 #2888, #3018 Bug fix Edit channel details ✔️

@radinamatic
Copy link
Copy Markdown
Member

radinamatic commented May 13, 2021

Petar's QA pass did not uncover any problems, so this is good to go in production @bjester! 🎉

@bjester bjester mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radinamatic radinamatic radinamatic approved these changes

Assignees

No one assigned

Labels

TODO: needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bjester @radinamatic @rtibbles @MisRob @sophianyberg @sairina