Enhance email regex to catch common errors#3130
Merged
rtibbles merged 1 commit intolearningequality:unstablefrom May 3, 2021
Merged
Enhance email regex to catch common errors#3130rtibbles merged 1 commit intolearningequality:unstablefrom
rtibbles merged 1 commit intolearningequality:unstablefrom
Conversation
2eca062 to
0fa3121
Compare
marcellamaki
approved these changes
May 3, 2021
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Looks good to me! (And good email resource - bookmarking that for future reference!)
Member
|
Tested at hotfixes.studio.learningequality.org - both sending invitations and the new email validation function correctly and as described. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Adds some extra restrictions to the email validation to protect against
<and>being wrapped around email addresses.Adds many tests to ensure we are not being too restrictive of valid email addresses, adds some tests of other emails we can safely exclude.
Examples drawn from here: https://en.wikipedia.org/wiki/Email_address#Examples
Manual verification steps performed
Unit tests
Reviewer guidance
How can a reviewer test these changes?
Check that valid email addresses can still have channels shared with them.
Check that
<this@this.com>cannot be shared with.References
Fixes #3021
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)