Skip to content

Add migration check to tests.#3128

Merged
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:migrations-ci-check
May 3, 2021
Merged

Add migration check to tests.#3128
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:migrations-ci-check

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Apr 29, 2021

Summary

Description of the change(s) you made

  • Adds a check for no ungenerated migrations to CI
  • Remove meaningless codecov reports.

Manual verification steps performed

Ran the command on the command line. It confirmed there were no ungenerated migrations.

References

Fixes #804
Command adapted from https://github.com/learningequality/kolibri/blob/develop/tox.ini#L28

Testing:

  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional

Remove meaningless codecov reports.
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjester bjester merged commit 88bf110 into learningequality:unstable May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI check that makemigrations doesn't generate a migration

2 participants