Skip to content

Use setData for model fetches as well as collection fetches.#3132

Merged
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:set_data_model
May 4, 2021
Merged

Use setData for model fetches as well as collection fetches.#3132
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:set_data_model

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented May 3, 2021

Summary

Description of the change(s) you made

  • Rectifies a massive oversight whereby only collection fetches had local changes applied to them
  • Uses the same setData logic as used in fetchCollection when we fetch a model that is stored in indexedDB

Manual verification steps performed

Follow the steps in Part 2 of #2888 (comment)

This is most easily done by increasing the sync interval in serverSync.js to something huge.

References

Fixes #2888
Fixes #3018

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from bjester May 3, 2021 22:28
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fixed the issues

@bjester bjester merged commit b7be4bd into learningequality:unstable May 4, 2021
@pcenov
Copy link
Copy Markdown
Member

pcenov commented May 13, 2021

Tested at hotfixes.studio.learningequality.org - didn't stumble upon any issues with the channel details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants