New feature: Add webm file format to Studio#2973
New feature: Add webm file format to Studio#2973bjester merged 13 commits intolearningequality:unstablefrom
Conversation
Codecov Report
@@ Coverage Diff @@
## unstable #2973 +/- ##
============================================
- Coverage 86.13% 85.72% -0.41%
============================================
Files 305 300 -5
Lines 16455 15891 -564
============================================
- Hits 14173 13623 -550
+ Misses 2282 2268 -14
Continue to review full report at Codecov.
|
|
This feature will presumably need to be added to the user documentation and have proper steps for testing added in the Gherkin scenarios, so I've added the labels 🙂 |
|
Looking through the code this looks like we have all the right changes in place. This change feels simultaneously slightly risky, and also not risky at all. Wondering if we might want to just have it in its own encapsulated release for focal testing. |
|
Since there needs to be changes made to documentation, Gherkin, etc. per @radinamatic , perhaps its own release would be best? |
|
Let's get this into the next batch to hotfixes and check how this flies with Kolibri! |
|
@rtibbles Do migrations get applied prior to the new migrations check ( |
|
No, but they shouldn't need to, as Django bases its migrations checking off code, not the DB. |
|
Tested at https://hotfixes.studio.learningequality.org/ - all looks good. Noticed that WebM videos cannot be uploaded or played in my Safari 13.1.3 on MacOS Catalina 10.15.7 but read online that with the release of macOS Big Sur 11.3 Safari can play WebM videos. |
Description
We added the video format
webmfor use in Studio both in the Studio code as well as pulled in the updatedle-utilsdependency.Steps to Test
Ricecooker-created channel
ricecooker.webmfile to a video node (via URL or upload from your computer)webmvideo and check to see that it playsManually-created channel
.webmextension (click on Add > Upload files)Implementation Notes (optional)
At a high level, how did you implement this?
Added a new file format in
le-utils, pulled that into Studio, updated associated files, tests, language strings to includewebmfiles, and updated DB to includewebmas an option for one of the fields.Checklist
Delete any items that don't apply
docslabel been added if this introduces a change that needs to be updated in the user docs?CHANGELOGlabel been added to this pull request? Items with this label will be added to the CHANGELOG at a later timepages,components, andlayoutsdirectories as described in the docs?Comments
Any additional notes you'd like to add
Reviewers
If you are looking to assign a reviewer, here are some options: