Skip to content

LIMS-1530: Add To Queue Fails when Not Completed filter applied#864

Merged
ndg63276 merged 2 commits into
pre-release/2024-R5.3from
fix/LIMS-1530/add-to-queue-fails
Dec 3, 2024
Merged

LIMS-1530: Add To Queue Fails when Not Completed filter applied#864
ndg63276 merged 2 commits into
pre-release/2024-R5.3from
fix/LIMS-1530/add-to-queue-fails

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1530

Summary:

Filtering subsamples by "Not Completed" or "Without Data" breaks the inidvidual "+" (add to queue) buttons and the "Add Current Page to Queue" button for anything but the first page of samples. They are added to the queue but not displayed in the lower half of the page.

Changes:

  • Rerun the onSubsamplesReady function after changing the "Not Completed" or "Without Data" filters, which regenerates the internal list to keep track of pages

To test:

  • Go to proposal nt37104, go to /containers, go to a container which is "in_storage"
  • Click "Mark Point" and click a couple of locations in a well, to generate some manual subsamples, then click "Finish"
  • Click "Prepare For Data Collection" to go to /containers/queue/<containerid>
  • Add a couple of samples to the queue by clicking the plus button next to them, check they appear in the lower half of the screen immediately, and remain so after a refresh
  • Repeat this for some samples on a page other than page 1
  • Check the "Add Current Page to Queue" button works for page 1 and also later pages
  • Turn on the "Without Data" filter and repeat the tests above
  • Turn on the "Not Completed" filter and repeat the tests above
  • Turn on both the "Not Completed" and "Manual" filters, and repeat the tests above (there may not be more than one page)

@gfrn gfrn self-requested a review November 27, 2024 11:14
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.3 December 3, 2024 09:22
@ndg63276 ndg63276 merged commit 6b40dbb into pre-release/2024-R5.3 Dec 3, 2024
ndg63276 added a commit that referenced this pull request Dec 16, 2024
…882)

* LIMS-1498: Change name of processed data archive (#855)

* LIMS-1469: Fix download button on old summary page (#840)

* LIMS-1463: Always display Mesh3D data collections as grid scans (#845)

* LIMS-1515: Add energy value to data collections (#853)

* LIMS-261: Allow download of PDB files (#857)

* LIMS-1529: Fix fast ep model viewer (#858)

* LIMS-753: Allow LN2 topups as part of dewar history (#856)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied

* LIMS-1552: Remove old jquery (#871)

* LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848)

* LIMS-1458: Fix GitHub warnings (#841)

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
@ndg63276 ndg63276 deleted the fix/LIMS-1530/add-to-queue-fails branch April 22, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants