LIMS-1529: Fix fast ep model viewer#858
Merged
ndg63276 merged 1 commit intoNov 12, 2024
Merged
Conversation
Collaborator
|
https://local-oidc-test.diamond.ac.uk:8082/dc/map/id/15531187/aid/106290688 returns a 400 for me, is this expected? All others work flawlessly |
Collaborator
Author
Hmmm... not expected... works for me... EDIT: Probably the config variable, have added to the instructions. |
Collaborator
|
I've updated the configuration, it all seems to work now! Thank you! |
gfrn
approved these changes
Nov 7, 2024
ndg63276
added a commit
that referenced
this pull request
Dec 16, 2024
…882) * LIMS-1498: Change name of processed data archive (#855) * LIMS-1469: Fix download button on old summary page (#840) * LIMS-1463: Always display Mesh3D data collections as grid scans (#845) * LIMS-1515: Add energy value to data collections (#853) * LIMS-261: Allow download of PDB files (#857) * LIMS-1529: Fix fast ep model viewer (#858) * LIMS-753: Allow LN2 topups as part of dewar history (#856) * LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864) * LIMS-1530: Add To Queue Fails when Not Completed filter applied * LIMS-1552: Remove old jquery (#871) * LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848) * LIMS-1458: Fix GitHub warnings (#841) --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1529
Summary:
#821 introduced a bug where the CCP4 path was set correctly for Dimple and MrBump, but not for Fast EP jobs, so the mtz2map conversion would fail and the map would not load.
Changes:
$CCP4_MASTERetc out of the if clauseTo test:
$ccp4_location = '/dls_sw/apps/ccp4/latest/ccp4-9';in your config.php file