[LIMS-1552] Remove old jQuery version#861
Merged
Merged
Conversation
ndg63276
approved these changes
Nov 18, 2024
Collaborator
ndg63276
left a comment
There was a problem hiding this comment.
For reference, here's the commit where the sign handler stuff was added.
Seems like removing it might break loading files internal links from within log files, but they don't work anyway, and there are much easier ways to get to the files.
ndg63276
added a commit
that referenced
this pull request
Dec 3, 2024
* [LIMS-1552] Remove old jQuery version (#861) * Remove old jQuery version * Remove desktop jQuery * LIMS-1530: Add To Queue Fails when Not Completed filter applied --------- Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk> Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1552
Summary:
A minified version of jQuery which was only used in one function was found, and since that function has little to no effect on the surrounding environment (logfiles), it may be possible to remove it completely.
I've tested Fast DP reports and autoPROC log files, and both of them don't see any penalty in terms of usability. AutoPROC files link resources as b64 blobs, so there are no authorised requests being made.
Changes:
iframeTo test:
Note that the list of autoprocessing programs is not exhaustive, and other logfile types may be affected by this. I need help mapping out which logfiles could be affected.