Skip to content

LIMS-1463: Always display Mesh3D data collections as grid scans#845

Merged
ndg63276 merged 2 commits into
pre-release/2024-R5.2from
improvement/LIMS-1463/always-display-mesh3d-dcs-as-grid-scans
Nov 12, 2024
Merged

LIMS-1463: Always display Mesh3D data collections as grid scans#845
ndg63276 merged 2 commits into
pre-release/2024-R5.2from
improvement/LIMS-1463/always-display-mesh3d-dcs-as-grid-scans

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Oct 9, 2024

JIRA ticket: LIMS-1463

Summary:

When Hyperion adds a Mesh3D experiment to ISPyB, Synchweb initially displays it as a rotational data collection, only updating to a grid scan style after a refresh. We should detect that it is a grid scan immediately.

Changes:

  • Treat the experiment type Mesh3d (ie hyperion grid scans) the same as Mesh (ie GDA grid scans)
  • Force both to display as grid scans, irrespective of the axis range and number of images

To test:

  • View a stopped Hyperion grid scan (eg /dc/visit/cm37235-4/dcg/13099843) check it displays in the style of a grid scan, ie space for a diffraction image and space for a crystal snapshot, no space for a graph of spot counts
  • View a completed Hyperion grid scan (eg /dc/visit/cm37235-4/dcg/13087189), check it displays in the style of a grid scan (ie unchanged)
  • View a GDA grid scan (eg /dc/visit/cm37236-4/id/15488302), check it displays in the style of a grid scan (ie unchanged)
  • View a "SAD" data collection (eg /dc/visit/cm37236-4/id/15488314), check it is unchanged from production)
  • View a "Serial Fixed" (eg /dc/visit/cy37017-1/id/15324649) and "Serial Jet" (eg /dc/visit/cm37275-4/id/14945838) experiment, check they are unchanged from production

@NKatti2011 NKatti2011 self-requested a review October 14, 2024 13:56
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.2 November 12, 2024 10:03
@ndg63276 ndg63276 merged commit 4452872 into pre-release/2024-R5.2 Nov 12, 2024
@ndg63276 ndg63276 deleted the improvement/LIMS-1463/always-display-mesh3d-dcs-as-grid-scans branch November 12, 2024 10:06
ndg63276 added a commit that referenced this pull request Dec 16, 2024
…882)

* LIMS-1498: Change name of processed data archive (#855)

* LIMS-1469: Fix download button on old summary page (#840)

* LIMS-1463: Always display Mesh3D data collections as grid scans (#845)

* LIMS-1515: Add energy value to data collections (#853)

* LIMS-261: Allow download of PDB files (#857)

* LIMS-1529: Fix fast ep model viewer (#858)

* LIMS-753: Allow LN2 topups as part of dewar history (#856)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied

* LIMS-1552: Remove old jquery (#871)

* LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848)

* LIMS-1458: Fix GitHub warnings (#841)

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants