LIMS-753: Allow LN2 topups as part of dewar history#856
Merged
ndg63276 merged 1 commit intoDec 3, 2024
Merged
Conversation
gfrn
approved these changes
Nov 11, 2024
ndg63276
added a commit
that referenced
this pull request
Dec 16, 2024
…882) * LIMS-1498: Change name of processed data archive (#855) * LIMS-1469: Fix download button on old summary page (#840) * LIMS-1463: Always display Mesh3D data collections as grid scans (#845) * LIMS-1515: Add energy value to data collections (#853) * LIMS-261: Allow download of PDB files (#857) * LIMS-1529: Fix fast ep model viewer (#858) * LIMS-753: Allow LN2 topups as part of dewar history (#856) * LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864) * LIMS-1530: Add To Queue Fails when Not Completed filter applied * LIMS-1552: Remove old jquery (#871) * LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848) * LIMS-1458: Fix GitHub warnings (#841) --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-753
Summary:
We record every time a dewar is topped up with LN2, but in the
Dewar.commentsfield. In order to let the users know what has happened to their dewar, we should record it in theDewarTransportHistorytable.Once this code is live, I can edit the Dewar Logistics code to use this endpoint instead.
Changes:
shipments/dewars/historyendpoint with aSTATUSinstead of aLOCATION.DewarTransportHistory(and notDewar) if onlySTATUSgivenTo test:
$bcrvariable in config.php to include the IP of a machine you can ping your server fromIf you get a 401 response, double check the $bcr variable. If you get a 200, go the dewar page on your Synchweb instance and check if the status has been added to the history. If no history shows, you might need to remove your IP from $bcr, it can get in the way. It should look like this:

LOCATIONsent in instead ofSTATUS. Check the dewar location has changed in both theDewarandDewarTransportHistorytables.