Skip to content

LIMS-1469: Fix download button on old summary page#840

Merged
ndg63276 merged 1 commit into
pre-release/2024-R5.2from
fix/LIMS-1469/download-button-fails-on-old-summary
Nov 12, 2024
Merged

LIMS-1469: Fix download button on old summary page#840
ndg63276 merged 1 commit into
pre-release/2024-R5.2from
fix/LIMS-1469/download-button-fails-on-old-summary

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1469

Summary:

On the (old) summary page, there is a button marked "Download MTZ file", but it just gives a 404 error. It appears the API endpoint was removed in 2b78502 (see changes to Download.php).

Changes:

  • Change link from /download/id/<%-DCID%>/aid/<%-AID%> to /download/ap/archive/<%-AID%> to match the new endpoint
  • Remove old "delete me" comment

To test:

  • Go to a summary page for a visit eg /dc/summary/visit/cm37235-4
  • Check the tooltip for the download button now says "Download autoprocessing archive"
  • Check clicking the button downloads a zip of autoprocessing files

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.2 November 12, 2024 10:03
@ndg63276 ndg63276 merged commit 9317745 into pre-release/2024-R5.2 Nov 12, 2024
@ndg63276 ndg63276 deleted the fix/LIMS-1469/download-button-fails-on-old-summary branch November 12, 2024 10:06
ndg63276 added a commit that referenced this pull request Dec 16, 2024
…882)

* LIMS-1498: Change name of processed data archive (#855)

* LIMS-1469: Fix download button on old summary page (#840)

* LIMS-1463: Always display Mesh3D data collections as grid scans (#845)

* LIMS-1515: Add energy value to data collections (#853)

* LIMS-261: Allow download of PDB files (#857)

* LIMS-1529: Fix fast ep model viewer (#858)

* LIMS-753: Allow LN2 topups as part of dewar history (#856)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied

* LIMS-1552: Remove old jquery (#871)

* LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848)

* LIMS-1458: Fix GitHub warnings (#841)

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants