Skip to content

LIMS-2162: Dont change dewar status if already dispatch-booked#1067

Merged
ndg63276 merged 1 commit into
pre-release/2026-R2.4from
fix/LIMS-2162/dont-change-dewar-status-if-already-booked
May 7, 2026
Merged

LIMS-2162: Dont change dewar status if already dispatch-booked#1067
ndg63276 merged 1 commit into
pre-release/2026-R2.4from
fix/LIMS-2162/dont-change-dewar-status-if-already-booked

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2162

Summary:

When a dewar location changes to eg the Randex, we update the location and also the status to at facility. Since #856, we have not updated the status if it was already dispatch-requested, so the dispatch request remains visible. #1049 introduced the new status of dispatch-booked, this PR is to treat dispatch-booked in the same way as dispatch-requested.

Changes:

  • Check for both dispatch-booked and dispatch-requested before changing status to at facility.

To test:

  • Using ispyb-test, go to (or create) a UK shipment (mx23694 usually has a couple of Selenium test ones), then do a dispatch request via the shipping service. The shipment should have a status of dispatch-booked
  • Add your local IP to the $bcr config variable, then send a POST request to /api/shipment/dewars/history, with the body of {"BARCODE": <your dewar barcode>, "LOCATION": "TRAY-17P"}
  • Check (in ispyb-test) the dewar now has a location of "tray-17p", but the status is still dispatch-booked. Check the dewar history agrees.
  • Take your IP out of $bcr as it messes up other things (eg dewar history)

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.4 May 7, 2026 09:54
@ndg63276 ndg63276 merged commit 923addf into pre-release/2026-R2.4 May 7, 2026
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-2162/dont-change-dewar-status-if-already-booked branch May 7, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants