Conversation
…nodes for channel
…rom old Studio default language
…e node already existing.
Prevent reference before assignment error
Check for $refs.editView before calling immediateSaveAll method
Count every resource even if the content_id is repeated
Don't filter for ancestors if target is root node
Disable the login button while the login request is running
Add additional language field check
Move and update size calculations for nodes.
Add additional fields for pending channels
Co-authored-by: Devon Rueckner <indirectlylit@users.noreply.github.com>
Co-authored-by: Devon Rueckner <indirectlylit@users.noreply.github.com>
Co-authored-by: Devon Rueckner <indirectlylit@users.noreply.github.com>
Co-authored-by: Devon Rueckner <indirectlylit@users.noreply.github.com>
Update PR and issue templates
Fix support for legacy clipboard nodes and Vuex handling for newer clipboard nodes
This was referenced Mar 2, 2021
Member
|
@metodimilevqa & I confirmed all the fixes included in this release, some follow-up issues remain to be addressed in the future ones. I'll approve the PR to get the release merged in production as there seem to be no regressions, but I do have one comment regarding the clipboard navigation: using Firefox still gives painfully slower experience compared to Chrome 😞 I have not seen consistently replicable errors in the console, but someone with many nodes in the clipboard (as probably many serious curators do), responsiveness of Studio in Firefox while navigating (opening & closing) nested topics will be a serious patience stress test. |
radinamatic
approved these changes
Mar 2, 2021
Member
radinamatic
left a comment
There was a problem hiding this comment.
UXening is ready to fly!!! 👍🏽
micahscopes
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes for:
#2895:
Test 1 (no errors/regressions): Create a new channel as a user without a default language set. Don't add a language. On close, you should see a front-end validation error and be prompted to fill in the language before the form closes.
Test 2 (to account for this edge case): Create a new channel as a user with a default language that had been previously set. Don't add a language. On close, you should see a front-end validation error and be prompted to fill in the language before the form closes.
#2904 - Unsure how to replicate for user, backend only change.
#2977 - Check that publish modal does not appear briefly after sync task is started
#2757 - Check that Khan Academy has the same number of resources listed on its Channel card as in the channel edit/view page
#2988 - Check that you can delete a channel from that channel's channel edit page
#2889 - Create a new channel, check that the ADD text shows up
#2927 - Ensure that you can copy from the clipboard into an empty channel
#2937 - In Chrome dev tools 'Network' tab, set Network connection to '3G' to ensure a slower connection. Try to login, ensure that the login button disables after a first click.
#2470 - Ensure that you can move content from the clipboard into a channel
#2724 - Ensure that content disappears when deleted from the clipboard
#2802 - Ensure that content copied into the clipboard before the relaunch is able to be unfolded, seen, and moved into a channel
#2818 - Ensure that selecting content in the clipboard by just selecting the checkbox next to the channel will cause them to be copied
N.B.
This includes a lot of changes to the clipboard in general, so doing a full pass on the clipboard would be helpful.