Count every resource even if the content_id is repeated#2986
Merged
jredrejo merged 1 commit intolearningequality:hotfixesfrom Feb 24, 2021
Merged
Count every resource even if the content_id is repeated#2986jredrejo merged 1 commit intolearningequality:hotfixesfrom
jredrejo merged 1 commit intolearningequality:hotfixesfrom
Conversation
This was referenced Feb 23, 2021
rtibbles
approved these changes
Feb 23, 2021
Codecov Report
@@ Coverage Diff @@
## hotfixes #2986 +/- ##
============================================
+ Coverage 80.80% 85.74% +4.94%
============================================
Files 281 298 +17
Lines 12659 15845 +3186
============================================
+ Hits 10229 13587 +3358
+ Misses 2430 2258 -172
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Counts every resource in a channel even , ignoring if the content_id is repeated, so different resources with the same content and different languages are considered.
Issue Addressed (if applicable)
Closes #2757
Steps to Test
Implementation Notes (optional)
Easiest fix in a long time (after you know what the problem is)