Skip to content

Count every resource even if the content_id is repeated#2986

Merged
jredrejo merged 1 commit intolearningequality:hotfixesfrom
jredrejo:remove_dedupe
Feb 24, 2021
Merged

Count every resource even if the content_id is repeated#2986
jredrejo merged 1 commit intolearningequality:hotfixesfrom
jredrejo:remove_dedupe

Conversation

@jredrejo
Copy link
Copy Markdown
Member

Description

Counts every resource in a channel even , ignoring if the content_id is repeated, so different resources with the same content and different languages are considered.

Issue Addressed (if applicable)

Closes #2757

Steps to Test

  1. In the main channels page select any channel, and take note of the number of resources
  2. Open the channel and count the number of resources for every topic, adding them all must match with the number in 1

Implementation Notes (optional)

Easiest fix in a long time (after you know what the problem is)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2986 (4516d52) into hotfixes (28587f8) will increase coverage by 4.94%.
The diff coverage is 92.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #2986      +/-   ##
============================================
+ Coverage     80.80%   85.74%   +4.94%     
============================================
  Files           281      298      +17     
  Lines         12659    15845    +3186     
============================================
+ Hits          10229    13587    +3358     
+ Misses         2430     2258     -172     
Impacted Files Coverage Δ
contentcuration/contentcuration/decorators.py 56.60% <50.00%> (-37.60%) ⬇️
...ntentcuration/contentcuration/db/models/manager.py 91.20% <90.98%> (-8.80%) ⬇️
contentcuration/contentcuration/forms.py 82.35% <94.04%> (+33.89%) ⬆️
contentcuration/contentcuration/api.py 92.06% <100.00%> (+1.43%) ⬆️
...tentcuration/contentcuration/context_processors.py 100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py 100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py 93.33% <100.00%> (-6.67%) ⬇️
...entcuration/contentcuration/db/models/functions.py 100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py 36.93% <0.00%> (-63.07%) ⬇️
contentcuration/contentcuration/utils/format.py 21.05% <0.00%> (-49.54%) ⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e1b5a...07ad1e7. Read the comment docs.

@jredrejo jredrejo merged commit 36be118 into learningequality:hotfixes Feb 24, 2021
@jredrejo jredrejo deleted the remove_dedupe branch February 24, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Channels page the number of resources shown in a channel card is different than the actual number of resources in this channel

2 participants