On-click the toolbar Copy button resources are not copied in the Clipboard if their channel's title is checked

[metodimilevqa]

Summary

When the user selects the checkbox of a channel title in the Clipboard and clicks the Copy button from the toolbar no resources from this channel are copied below.

Category

BUG

Usage Details

Tested at: https://studio.learningequality.org/

• Windows 10
• Browser: Chrome, Firefox, Edge (latest)

How to reproduce

Preconditions: Channels created

1. Login to Studio
2. Click a channel
3. Select some topics/resources and click Copy to Clipboard
4. Click the floating Clipboard button to toggle the clipboard
5. Select the checkbox of the channel's title
6. Click the Copy button from the dynamic toolbar
7. See the copy is missing below the original

Screenshots

Real-life consequences (anything community should be aware of, for instance how it affects end users)

Users are not able to copy resources in the Clipboard when their channel's title is selected.

Console error

TypeError: Cannot read property 'node_id' of null
    at recurseforCopy (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at Object.<anonymous> (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at Sub.<anonymous> (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at Sub.calculateMoveNodes (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at click (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at invokeWithErrorHandling (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at Sub.invoker (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at invokeWithErrorHandling (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at Sub.Vue.$emit (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at Sub.handleClick (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at invokeWithErrorHandling (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at HTMLButtonElement.invoker (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at HTMLButtonElement.original._wrapper (channel_edit-8cf67e0286b0b120e2ed.js:1)
    at HTMLButtonElement.nrWrapper ((index):52)
    at HTMLButtonElement.sentryWrapped (helpers.ts:85)

[bjester]

This is caused by the same issue as #2470

[metodimilevqa]

I confirm the fix is successful with #3000

[radinamatic]

This issue is fixed for the new topics included in the clipboard, but I'm still unable to make a copy of the topics/resources that were part of my clipboard from the old Studio. Was that also the scope of the fix, or did I misinterpret the term legacy here...?

cc @rtibbles @bjester

[rtibbles]

Duplicating a legacy node within the clipboard is still disallowed - the fixes were to ensure proper display of the legacy nodes and allowing them to be moved into channels.