Don't filter for ancestors if target is root node#2992
Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom Feb 25, 2021
Merged
Don't filter for ancestors if target is root node#2992rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles merged 2 commits intolearningequality:hotfixesfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfixes #2992 +/- ##
============================================
+ Coverage 80.80% 85.80% +4.99%
============================================
Files 281 298 +17
Lines 12659 15875 +3216
============================================
+ Hits 10229 13621 +3392
+ Misses 2430 2254 -176
Continue to review full report at Codecov.
|
rtibbles
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This issue was caused by a pending call to get the ancestors of the root node of the channel, which blocked the loading of the page and thereby prevented copying. Unfortunately, this ancestors call can take several seconds on hotfixes and production (90 seconds on hotfixes for me once), even though the root node has no ancestors. This PR makes a change to take a shortcut in that scenario to only return the target node.
Issue Addressed (if applicable)
Addresses #2927
Addresses #2889
Steps to Reproduce/Test
Checklist