Skip to content

Disable the login button while the login request is running#2995

Merged
micahscopes merged 1 commit intolearningequality:hotfixesfrom
MisRob:prevent-many-login-requests
Feb 26, 2021
Merged

Disable the login button while the login request is running#2995
micahscopes merged 1 commit intolearningequality:hotfixesfrom
MisRob:prevent-many-login-requests

Conversation

@MisRob
Copy link
Copy Markdown
Member

@MisRob MisRob commented Feb 25, 2021

Description

Disable the login button while the login request is running to prevent subsequent clicks and more active login requests than one at a time.

Issue Addressed

Closes #2937

Before/After Screenshots

After

Peek 2021-02-25 10-44

Steps to Test

  • Follow steps to reproduce of the issue addressed. There should be no multiple overlapping requests.
  • Check that you can successfully login with correct credentials

Copy link
Copy Markdown
Contributor

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@micahscopes micahscopes merged commit dc339ca into learningequality:hotfixes Feb 26, 2021
@radinamatic
Copy link
Copy Markdown
Member

Confirming that the issue is fixed on current hotfixes branch! 💯

@MisRob MisRob deleted the prevent-many-login-requests branch March 15, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submitting login form doesn't give feedback that it's processing

4 participants