Skip to content

fix(web): improve marketplace install dialog accessibility#38798

Merged
lyzno1 merged 1 commit into
mainfrom
codex/fix-marketplace-install-dialog-a11y
Jul 12, 2026
Merged

fix(web): improve marketplace install dialog accessibility#38798
lyzno1 merged 1 commit into
mainfrom
codex/fix-marketplace-install-dialog-a11y

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Expose the current installation step through DialogTitle so the dialog has an accessible name.
  • Keep the close control in the focus loop while allowing the first step-owned safe action to receive initial focus.
  • Cover the accessible name, initial focus, and failed-state title with focused tests.

Root cause

The visible heading was a plain div, so assistive technology could not derive the dialog name from it. The close button also appeared before the step content in DOM order, causing the focus manager to select it as the default initial focus target.

Validation

  • pnpm --dir web test -- app/components/plugins/install-plugin/install-from-marketplace/tests/index.spec.tsx (64 tests passed)
  • pnpm --dir web type-check
  • git diff --check

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 12, 2026
@lyzno1 lyzno1 marked this pull request as ready for review July 12, 2026 10:56
@lyzno1 lyzno1 requested review from iamjoel and zhsama as code owners July 12, 2026 10:56
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 12, 2026
@lyzno1 lyzno1 enabled auto-merge July 12, 2026 10:56
@lyzno1 lyzno1 marked this pull request as draft July 12, 2026 10:56
auto-merge was automatically disabled July 12, 2026 10:56

Pull request was converted to draft

@lyzno1 lyzno1 marked this pull request as ready for review July 12, 2026 10:57
@lyzno1 lyzno1 enabled auto-merge July 12, 2026 10:57
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.47%. Comparing base (6e5ba18) to head (d5a81f0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38798      +/-   ##
==========================================
- Coverage   85.47%   85.47%   -0.01%     
==========================================
  Files        5025     5025              
  Lines      273457   273457              
  Branches    51259    51259              
==========================================
- Hits       233729   233728       -1     
- Misses      35238    35239       +1     
  Partials     4490     4490              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 85.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jul 12, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
Merged via the queue into main with commit 3defd50 Jul 12, 2026
38 checks passed
@lyzno1 lyzno1 deleted the codex/fix-marketplace-install-dialog-a11y branch July 12, 2026 14:26
BlueSkyXN added a commit to BlueSkyXN/dify that referenced this pull request Jul 12, 2026
* fix(web): improve marketplace install dialog accessibility (langgenius#38798)

* refactor(web): normalize z-index layering (langgenius#38796)

* fix(web): correct knowledge dialog draft state (langgenius#38794)

* fix(agent-v2): restore keyboard access to row actions (langgenius#38792)

* fix(web): split model selection and settings actions (langgenius#38797)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: eagerly validate conversation on service-api and explore chat endpoints (langgenius#38801)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants