fix(web): improve marketplace install dialog accessibility#38798
Merged
Conversation
auto-merge was automatically disabled
July 12, 2026 10:56
Pull request was converted to draft
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38798 +/- ##
==========================================
- Coverage 85.47% 85.47% -0.01%
==========================================
Files 5025 5025
Lines 273457 273457
Branches 51259 51259
==========================================
- Hits 233729 233728 -1
- Misses 35238 35239 +1
Partials 4490 4490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
approved these changes
Jul 12, 2026
BlueSkyXN
added a commit
to BlueSkyXN/dify
that referenced
this pull request
Jul 12, 2026
* fix(web): improve marketplace install dialog accessibility (langgenius#38798) * refactor(web): normalize z-index layering (langgenius#38796) * fix(web): correct knowledge dialog draft state (langgenius#38794) * fix(agent-v2): restore keyboard access to row actions (langgenius#38792) * fix(web): split model selection and settings actions (langgenius#38797) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: eagerly validate conversation on service-api and explore chat endpoints (langgenius#38801) Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The visible heading was a plain div, so assistive technology could not derive the dialog name from it. The close button also appeared before the step content in DOM order, causing the focus manager to select it as the default initial focus target.
Validation