Skip to content

fix(web): split model selection and settings actions#38797

Merged
lyzno1 merged 3 commits into
mainfrom
codex/fix-model-selector-split-trigger
Jul 12, 2026
Merged

fix(web): split model selection and settings actions#38797
lyzno1 merged 3 commits into
mainfrom
codex/fix-model-selector-split-trigger

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 12, 2026

Copy link
Copy Markdown
Member

What changed

  • split the shared model control into independent model selection and model settings actions
  • open the model list from the primary trigger and current-model parameters from the settings trigger
  • disable model settings when no model is selected or the control is read-only
  • apply the same contract to the main LLM model parameter control and the general plugin model selector

Why

The controls were visually presented as split buttons, but one popover trigger wrapped both regions. As a result, clicking either side opened model settings and the primary model-selection action was unavailable.

Impact

Default callers now get consistent split-button behavior from the shared owners without call-site wiring. Custom combined triggers and agent strategy triggers keep their existing behavior.

Validation

  • pnpm -C web test app/components/header/account-setting/model-provider-page/model-parameter-modal/__tests__/index.spec.tsx app/components/plugins/plugin-detail-panel/model-selector/__tests__/index.spec.tsx app/components/workflow/nodes/llm/__tests__/panel.spec.tsx app/components/header/account-setting/model-provider-page/model-selector/__tests__/index.spec.tsx --run --reporter=dot
  • pnpm -C web type-check
  • git diff --check

Refs SNP-530

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 12, 2026
@lyzno1 lyzno1 marked this pull request as ready for review July 12, 2026 10:53
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 12, 2026
@lyzno1 lyzno1 enabled auto-merge July 12, 2026 10:53
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.46%. Comparing base (6e5ba18) to head (658b400).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38797      +/-   ##
==========================================
- Coverage   85.47%   85.46%   -0.01%     
==========================================
  Files        5025     5023       -2     
  Lines      273457   273438      -19     
  Branches    51259    51255       -4     
==========================================
- Hits       233729   233707      -22     
- Misses      35238    35241       +3     
  Partials     4490     4490              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 85.14% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jul 12, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
Merged via the queue into main with commit 594c21d Jul 12, 2026
39 checks passed
@lyzno1 lyzno1 deleted the codex/fix-model-selector-split-trigger branch July 12, 2026 14:38
BlueSkyXN added a commit to BlueSkyXN/dify that referenced this pull request Jul 12, 2026
* fix(web): improve marketplace install dialog accessibility (langgenius#38798)

* refactor(web): normalize z-index layering (langgenius#38796)

* fix(web): correct knowledge dialog draft state (langgenius#38794)

* fix(agent-v2): restore keyboard access to row actions (langgenius#38792)

* fix(web): split model selection and settings actions (langgenius#38797)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: eagerly validate conversation on service-api and explore chat endpoints (langgenius#38801)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-linear lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants