Skip to content

fix(web): correct knowledge dialog draft state#38794

Merged
lyzno1 merged 2 commits into
mainfrom
codex/fix-agent-v2-knowledge-dialog-state
Jul 12, 2026
Merged

fix(web): correct knowledge dialog draft state#38794
lyzno1 merged 2 commits into
mainfrom
codex/fix-agent-v2-knowledge-dialog-state

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary

  • scope knowledge dialog state to a single open session and keep React state updaters pure
  • isolate inline name editing with commit, cancel, IME, and focus restoration behavior
  • avoid persisting derived rerank settings during unrelated draft edits and align the title button/input box model
  • replace CSS implementation assertions with user-visible draft, keyboard, focus, and config preservation coverage

Testing

  • pnpm -C web test features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/__tests__/index.spec.tsx
  • pnpm -C web exec eslint features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/dialog.tsx features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/__tests__/index.spec.tsx
  • pnpm -C web type-check
  • git diff --check

@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 11, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 11, 2026
@lyzno1 lyzno1 enabled auto-merge July 11, 2026 13:04
@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.29730% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.48%. Comparing base (6e5ba18) to head (0220441).

Files with missing lines Patch % Lines
...figure/components/orchestrate/knowledge/dialog.tsx 71.12% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38794      +/-   ##
==========================================
+ Coverage   85.47%   85.48%   +0.01%     
==========================================
  Files        5025     5025              
  Lines      273457   273428      -29     
  Branches    51259    51252       -7     
==========================================
+ Hits       233729   233739      +10     
+ Misses      35238    35199      -39     
  Partials     4490     4490              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 85.18% <72.29%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 requested review from iamjoel and zxhlyh as code owners July 11, 2026 13:22
@lyzno1 lyzno1 added this pull request to the merge queue Jul 12, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
Merged via the queue into main with commit 2a2193d Jul 12, 2026
37 of 38 checks passed
@lyzno1 lyzno1 deleted the codex/fix-agent-v2-knowledge-dialog-state branch July 12, 2026 14:30
BlueSkyXN added a commit to BlueSkyXN/dify that referenced this pull request Jul 12, 2026
* fix(web): improve marketplace install dialog accessibility (langgenius#38798)

* refactor(web): normalize z-index layering (langgenius#38796)

* fix(web): correct knowledge dialog draft state (langgenius#38794)

* fix(agent-v2): restore keyboard access to row actions (langgenius#38792)

* fix(web): split model selection and settings actions (langgenius#38797)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: eagerly validate conversation on service-api and explore chat endpoints (langgenius#38801)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants