Skip to content

fix(agent-v2): restore keyboard access to row actions#38792

Merged
lyzno1 merged 1 commit into
mainfrom
codex/fix-agent-configurable-item-keyboard-focus
Jul 12, 2026
Merged

fix(agent-v2): restore keyboard access to row actions#38792
lyzno1 merged 1 commit into
mainfrom
codex/fix-agent-configurable-item-keyboard-focus

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary

  • keep configurable row actions in the keyboard tab order while visually hidden
  • reveal actions on hover or focus without reserving layout space
  • remove the class-level test that encoded the inaccessible display behavior

Testing

  • pnpm -C web test features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/tests/index.spec.tsx --run
  • pnpm -C web exec eslint features/agent-v2/agent-detail/configure/components/orchestrate/common/configurable-item.tsx features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/tests/index.spec.tsx
  • git diff --check

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 11, 2026
@lyzno1 lyzno1 marked this pull request as ready for review July 11, 2026 11:54
@lyzno1 lyzno1 enabled auto-merge July 11, 2026 11:54
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 11, 2026
@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (6e5ba18) to head (ba23797).

Files with missing lines Patch % Lines
...omponents/orchestrate/common/configurable-item.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #38792   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files        5025     5025           
  Lines      273457   273457           
  Branches    51259    51259           
=======================================
  Hits       233729   233729           
  Misses      35238    35238           
  Partials     4490     4490           
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 85.15% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jul 12, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
Merged via the queue into main with commit 6e59c72 Jul 12, 2026
37 of 38 checks passed
@lyzno1 lyzno1 deleted the codex/fix-agent-configurable-item-keyboard-focus branch July 12, 2026 14:38
BlueSkyXN added a commit to BlueSkyXN/dify that referenced this pull request Jul 12, 2026
* fix(web): improve marketplace install dialog accessibility (langgenius#38798)

* refactor(web): normalize z-index layering (langgenius#38796)

* fix(web): correct knowledge dialog draft state (langgenius#38794)

* fix(agent-v2): restore keyboard access to row actions (langgenius#38792)

* fix(web): split model selection and settings actions (langgenius#38797)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: eagerly validate conversation on service-api and explore chat endpoints (langgenius#38801)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants